From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] docs: make .txt files writable when
 building from r/o sources
Date: Fri, 4 Jul 2014 16:04:53 +0100
Message-ID: <53B6C295.7020207@citrix.com>
References: <53B6D9CF0200007800020CB9@mail.emea.novell.com>
	<53B6BE68.3000408@citrix.com>
	<53B6DB9A0200007800020CE6@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1X352o-00026c-7a
	for xen-devel@lists.xenproject.org; Fri, 04 Jul 2014 15:04:58 +0000
In-Reply-To: <53B6DB9A0200007800020CE6@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 04/07/14 15:51, Jan Beulich wrote:
>>>> On 04.07.14 at 16:47, <andrew.cooper3@citrix.com> wrote:
>> On 04/07/14 15:43, Jan Beulich wrote:
>>> Otherwise an incremental build will fail to overwrite the destination
>>> files.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>>> --- a/docs/Makefile
>>> +++ b/docs/Makefile
>>> @@ -125,6 +125,7 @@ endif
>>>  html/%.txt: %.txt
>>>  	$(INSTALL_DIR) $(@D)
>>>  	cp $< $@
>>> +	chmod u+w $@
>> Perhaps $(INSTALL_DATA) in preference to cp + chmod ?
> I wasn't certain about the validity of the INSTALL_DIR use in a non-
> install rule. If that's indeed fine, then INSTALL_DATA - if it does what
> I want - would likely be the better thing.
>
> Jan
>

Because of the somewhat-backwards way the rules are defined, these are
all implicit install rules.

The 'build' rules take the bits from man/ misc/ and figs/ and creates
appropriate structures under man1/ man5/ html/ txt/ and pdf/, while the
'install' rules merely copies the appropriate built structure into
$(DESTDIR)/$({mandir,docdir})

Given the presence of INSTALL_DIR, I would say INSTALL_DATA is
absolutely fine. (with the concession that INSTALL_DIR isn't exactly
nice in that location, as it a huge number of attempts to create
existing directories, and I haven't had sufficient free time to find a
nice fix)

~Andrew