From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] docs: make .txt files writable when building from r/o sources
Date: Fri, 04 Jul 2014 15:51:38 +0100 [thread overview]
Message-ID: <53B6DB9A0200007800020CE6@mail.emea.novell.com> (raw)
In-Reply-To: <53B6BE68.3000408@citrix.com>
>>> On 04.07.14 at 16:47, <andrew.cooper3@citrix.com> wrote:
> On 04/07/14 15:43, Jan Beulich wrote:
>> Otherwise an incremental build will fail to overwrite the destination
>> files.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>> --- a/docs/Makefile
>> +++ b/docs/Makefile
>> @@ -125,6 +125,7 @@ endif
>> html/%.txt: %.txt
>> $(INSTALL_DIR) $(@D)
>> cp $< $@
>> + chmod u+w $@
>
> Perhaps $(INSTALL_DATA) in preference to cp + chmod ?
I wasn't certain about the validity of the INSTALL_DIR use in a non-
install rule. If that's indeed fine, then INSTALL_DATA - if it does what
I want - would likely be the better thing.
Jan
next prev parent reply other threads:[~2014-07-04 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 14:43 [PATCH] docs: make .txt files writable when building from r/o sources Jan Beulich
2014-07-04 14:47 ` Andrew Cooper
2014-07-04 14:51 ` Jan Beulich [this message]
2014-07-04 15:04 ` Andrew Cooper
2014-07-25 14:56 ` [PATCH v2] docs: make .txt files over-writable " Jan Beulich
2014-07-25 15:24 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B6DB9A0200007800020CE6@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).