From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH v8 07/10] xen/arm: remove workaround to inject evtchn_irq on irq enable
Date: Fri, 11 Jul 2014 14:10:26 +0100 [thread overview]
Message-ID: <53BFE242.1090706@linaro.org> (raw)
In-Reply-To: <1405016003-19131-7-git-send-email-stefano.stabellini@eu.citrix.com>
Hi Stefano,
On 07/10/2014 07:13 PM, Stefano Stabellini wrote:
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 69188a4..ed43a4c 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -18,6 +18,7 @@
> #include <asm/psci.h>
>
> #include <asm/gic.h>
> +#include <asm/vgic.h>
> #include <xen/irq.h>
> #include "kernel.h"
>
> @@ -1378,6 +1379,8 @@ int construct_dom0(struct domain *d)
> }
> #endif
>
> + vgic_vcpu_inject_irq(v, v->domain->arch.evtchn_irq);
>
IHMO, it misses a comment here to explain why we inject an IRQ for the
event channel.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-11 13:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 18:12 [PATCH v8 00/10] gic and vgic fixes and improvements Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 01/10] xen/arm: observe itargets setting in vgic_enable_irqs and vgic_disable_irqs Stefano Stabellini
2014-07-11 13:01 ` Julien Grall
2014-07-23 15:31 ` Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 02/10] xen/arm: move setting GIC_IRQ_GUEST_QUEUED earlier Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 03/10] xen/arm: inflight irqs during migration Stefano Stabellini
2014-07-17 12:44 ` Ian Campbell
2014-07-23 14:45 ` Stefano Stabellini
2014-07-23 15:38 ` Ian Campbell
2014-07-24 14:48 ` Stefano Stabellini
2014-07-24 16:41 ` Ian Campbell
2014-07-24 16:45 ` Stefano Stabellini
2014-07-24 16:48 ` Ian Campbell
2014-07-24 16:49 ` Stefano Stabellini
2014-07-25 9:08 ` Ian Campbell
2014-07-10 18:13 ` [PATCH v8 04/10] xen/arm: support irq delivery to vcpu > 0 Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 05/10] xen/arm: physical irq follow virtual irq Stefano Stabellini
2014-07-11 13:07 ` Julien Grall
2014-07-23 15:00 ` Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 06/10] xen: introduce sched_move_irqs Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 07/10] xen/arm: remove workaround to inject evtchn_irq on irq enable Stefano Stabellini
2014-07-11 13:10 ` Julien Grall [this message]
2014-07-17 12:50 ` Ian Campbell
2014-07-23 15:04 ` Stefano Stabellini
2014-07-23 16:09 ` Stefano Stabellini
2014-07-23 16:11 ` Ian Campbell
2014-07-23 16:12 ` Stefano Stabellini
2014-07-23 16:16 ` Ian Campbell
2014-07-24 14:37 ` Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 08/10] xen/arm: take the rank lock before accessing ipriority Stefano Stabellini
2014-07-17 12:51 ` Ian Campbell
2014-07-23 14:57 ` Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 09/10] xen: introduce bit access macros for the IRQ line status flags Stefano Stabellini
2014-07-11 13:15 ` Julien Grall
2014-07-23 14:52 ` Stefano Stabellini
2014-07-10 18:13 ` [PATCH v8 10/10] xen/arm: make accesses to desc->status flags atomic Stefano Stabellini
2014-07-17 12:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFE242.1090706@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).