From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Armin Zentai <armin.zentai@ezit.hu>, xen-devel@lists.xen.org
Subject: Re: Trying to unmap invalid handle! pending_idx: @ drivers/net/xen-netback/netback.c:998 causes kernel panic/reboot
Date: Mon, 14 Jul 2014 13:27:32 +0100 [thread overview]
Message-ID: <53C3CCB4.2050604@citrix.com> (raw)
In-Reply-To: <53C3C7F3.5000905@citrix.com>
Hi,
I've already identified 2 issues in xenvif_tx_check_gop:
- (*gopp_copy)++ happens before we print the error message, though its
only effect that the error message becomes incorrect
- a more severe issue is that if there is a mapping problem on the frags
(or on the frag_list skb), AND the first TX request is entirely grant
copied ( !(data_len < txreq.size) in build_gops), that pending_idx is
never released. The frags are released but then the function returns,
skb is freed and the while loop goes to next iteration. In the normal
path it should be released a bit later in that loop, at the "Schedule a
response immediately" comment.
However, I don't see yet how this second issue should cause this problem.
Zoltan
next prev parent reply other threads:[~2014-07-14 12:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 2:25 Trying to unmap invalid handle! pending_idx: @ drivers/net/xen-netback/netback.c:998 causes kernel panic/reboot Armin Zentai
2014-07-14 9:52 ` Wei Liu
2014-07-14 10:53 ` Armin Zentai
2014-07-14 11:15 ` Wei Liu
2014-07-14 11:54 ` Zoltan Kiss
2014-07-14 12:07 ` Zoltan Kiss
2014-07-14 12:27 ` Zoltan Kiss [this message]
2014-07-14 12:14 ` Armin Zentai
2014-07-14 15:30 ` Zoltan Kiss
2014-07-14 21:15 ` Armin Zentai
2014-07-15 9:32 ` Wei Liu
2014-07-17 19:17 ` Zoltan Kiss
2014-07-20 17:20 ` Armin Zentai
2014-07-21 10:24 ` Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C3CCB4.2050604@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=armin.zentai@ezit.hu \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).