From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 2/3] xen: arm: when ALLOCATING p2m entries maddr is meaningless
Date: Mon, 14 Jul 2014 19:29:44 +0100 [thread overview]
Message-ID: <53C42198.7060700@linaro.org> (raw)
In-Reply-To: <1405355225-4623-2-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 07/14/2014 05:27 PM, Ian Campbell wrote:
> The maddr differs on each loop depending on the pages which happen to get
> allocated.
>
> There is already an assertion that maddr == 0.
I think we hit the assert we don't use 1:1 mapping for DOM0.
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/p2m.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 917baa3..a10cbaf 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -501,7 +501,6 @@ static int apply_one_level(struct domain *d,
> p2m->stats.mappings[level]++;
>
> *addr += level_size;
> - *maddr += level_size;
>
> return P2M_ONE_PROGRESS;
> }
>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-14 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 16:26 [PATCH 0/3] xen: arm: various p2m handling fixups Ian Campbell
2014-07-14 16:27 ` [PATCH 1/3] xen: arm: avoid reusing incorrect mappings when walking the p2m Ian Campbell
2014-07-14 18:17 ` Julien Grall
2014-07-15 9:36 ` Ian Campbell
2014-07-14 16:27 ` [PATCH 2/3] xen: arm: when ALLOCATING p2m entries maddr is meaningless Ian Campbell
2014-07-14 18:29 ` Julien Grall [this message]
2014-07-18 13:38 ` Ian Campbell
2014-07-14 16:27 ` [PATCH 3/3] xen: arm: correctly handle removing a subset of a superpage mapping Ian Campbell
2014-07-14 18:34 ` Julien Grall
2014-07-15 9:38 ` Ian Campbell
2014-07-15 12:13 ` Julien Grall
2014-07-18 12:51 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C42198.7060700@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).