xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Abhiroop Dabral <abhiroop.dabral@gmail.com>, xen-devel@lists.xen.org
Subject: Re: AMD NPT support for Xen memory events
Date: Wed, 16 Jul 2014 10:07:42 +0100	[thread overview]
Message-ID: <53C640DE.6020507@citrix.com> (raw)
In-Reply-To: <CAKuLJhBRuKTozO8TdvdsErDsN=4xDLETymnJ-ppxZp_KGmLGPA@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1232 bytes --]

On 16/07/14 05:38, Abhiroop Dabral wrote:
> Hi,
>
> I was looking at the code for the memory events for guest domain in
> "xen/arch/xen/mm/mem_event.c". In the function "mem_event_domctl()"
> for the case "XEN_DOMCTL_MEM_EVENT_OP_ACCESS", there is a comment that
> "Currently only EPT is supported" and then a check is made for the vmx
> presence and control returns if it is not Intel VT with an error. 
> I am trying to make the memory events working on AMD SVM with NPT
> support. 
> My question is that is there a specific reason why AMD NPT is
> supported there?
> The things I should keep in mind/work on to support the memory events
> on AMD NPT.
> (Working on Xen 4.4 on HVM guests (windows XP 32 bit -PAE)

I am not aware of any technical reasons why AMD support could not be added.

I don't know why there is still a VMX check.  c/s d928515d76 took out an
EPT check and that appears to have been fine.

Try it and see - it could be as easy as just deleting the vmx check.

It would certainly be nice to try and get some parity back in our
feature sets; a number of new features arrive as Intel-only because they
were developed on Intel systems, rather than a specific reason why the
feature wouldn't work on AMD.

~Andrew

[-- Attachment #1.2: Type: text/html, Size: 4735 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2014-07-16  9:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16  4:38 AMD NPT support for Xen memory events Abhiroop Dabral
2014-07-16  9:07 ` Andrew Cooper [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-07-16 18:11 Aravindh Puthiyaparambil (aravindp)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C640DE.6020507@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=abhiroop.dabral@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).