From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH ARM v6 05/14] mini-os: import libfdt
Date: Wed, 16 Jul 2014 12:44:58 +0100
Message-ID: <53C665BA.2010305@citrix.com>
References: <1405508874-3921-1-git-send-email-talex5@gmail.com>
	<1405508874-3921-6-git-send-email-talex5@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1X7Ndw-0006lM-WA
	for xen-devel@lists.xenproject.org; Wed, 16 Jul 2014 11:45:10 +0000
In-Reply-To: <1405508874-3921-6-git-send-email-talex5@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Thomas Leonard <talex5@gmail.com>, xen-devel@lists.xenproject.org
Cc: samuel.thibault@ens-lyon.org, stefano.stabellini@eu.citrix.com, Dave.Scott@eu.citrix.com, anil@recoil.org
List-Id: xen-devel@lists.xenproject.org

On 16/07/14 12:07, Thomas Leonard wrote:
> From: Karim Raslan <karim.allah.ahmed@gmail.com>
>
> Looks like this is revision v1.3.0-47-gbe60268 from
> http://git.jdl.com/gitweb/?p=dtc.git
>
> The memmove implementation is from FreeBSD's
> contrib/ldns/compat/memmove.c (r246827).
>
> Signed-off-by: Karim Allah Ahmed <karim.allah.ahmed@gmail.com>
> [talex5@gmail.com: split out FDT support into a separate patch]
> [talex5@gmail.com: fixed "make clean" for FDT]
> [talex5@gmail.com: replaced GPL memmove with BSD one]
> Signed-off-by: Thomas Leonard <talex5@gmail.com>

Xen already has a copy of libfdt in xen/common/libfdt.

I think it sets a poor precedent to have multiple different copies of
the same library in the source tree.

Libraries like this should live in their own part of the Xen source tree
(libs/ or perhaps common/) and each component wanting to use them (Xen,
libxc, mini-os) can VPATH themselves access to the headers/source.

This would have the added advantage of making it obvious which shared
libraries are used by multiple components in the tree (libelf is another
example), and avoids duplication and stagnation.

~Andrew