From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 5/5] make: Make "src-tarball" target
 actually make a source tarball
Date: Wed, 16 Jul 2014 18:45:33 +0100
Message-ID: <53C6BA3D.5060403@eu.citrix.com>
References: <1405354526-20929-1-git-send-email-george.dunlap@eu.citrix.com>	
	<1405354526-20929-5-git-send-email-george.dunlap@eu.citrix.com>	
	<21446.38146.96203.437720@mariner.uk.xensource.com>
	<1405529773.1087.88.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1405529773.1087.88.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 07/16/2014 05:56 PM, Ian Campbell wrote:
> On Wed, 2014-07-16 at 16:06 +0100, Ian Jackson wrote:
>> George Dunlap writes ("[PATCH 5/5] make: Make "src-tarball" target actually make a source tarball"):
>>> At the moment, making a release tarball is an annoyingly manual
>>> process that involves running "git archive" into a temporary directory.
>> ...
>>> +src-tarball: subtree-update
>>> +	bash ./tools/misc/mktarball $(XEN_ROOT) $$(git describe)
>>
>> Does this absolutely have to depend on subtree-update ?  Perhaps we
>> need a new "make the subtrees exist" target ?
>
> Given that he makes the force targets depend on the dir targets in one
> of the earlier patches I think subtree-update might already be that
> target...

I think he might have been thinking that it would be nice to be able to 
make a tarball without doing the force update -- i.e., if you had 
checked out a particular version of one of the trees, just use that; but 
if you hadn't checked anything out, go fetch the tree.

I could do that. :-)  It means SOP would have to be two steps "make 
subdir-update ; make src-tarball-release".  Personally I think it's a 
bit of a trap waiting to happen, but I can see the logic behind it.

  -George