From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen/arm: Implement domain_get_maximum_gpfn Date: Wed, 16 Jul 2014 19:17:20 +0100 Message-ID: <53C6C1B0.2020901@linaro.org> References: <1404226666-7949-1-git-send-email-julien.grall@linaro.org> <53BD29CD.4020204@linaro.org> <1405526542.1087.50.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X7Tlb-00014K-Ku for xen-devel@lists.xenproject.org; Wed, 16 Jul 2014 18:17:23 +0000 Received: by mail-wi0-f175.google.com with SMTP id ho1so6661986wib.14 for ; Wed, 16 Jul 2014 11:17:22 -0700 (PDT) In-Reply-To: <1405526542.1087.50.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Hi Ian, On 16/07/14 17:02, Ian Campbell wrote: > On Wed, 2014-07-09 at 12:38 +0100, Julien Grall wrote: >> Hi Ian, >> >> On 07/01/2014 05:57 PM, Stefano Stabellini wrote: >>> On Tue, 1 Jul 2014, Julien Grall wrote: >>>> The function domain_get_maximum_gpfn is returning the maximum gpfn ever >>>> mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose. >>>> >>>> Signed-off-by: Julien Grall >>> >>> Acked-by: Stefano Stabellini >> >> Following the discussion on this thread, I will send a patch to fix >> xc_dom_gnttab_hvm_seed at least for ARM. Not sure what to do on x86, I >> may keep the same behavior. >> >> I think this patch is still relevant and won't break things as we don't >> have platform with 48bits PA support. >> >> Ian, do I have your ack on this patch? > > Oops, when I first saw this I read the first para and stopped, sorry. > > I'd much prefer to just have the fix to xc_dom_gnttab_hvm_seed for ARM > and continue to punt on this interface until it is actually needed by > something unavoidable on the guest side (and simultaneously hope that > day never comes...). This hypercall is used in 2 difference locations: domain save, and dump core. I expect to have both working on Xen ARM soon. I will also send a fix when I will find time for xc_dom_gnttab_hvm_seed. Regards, -- Julien Grall