From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH ARM v6 04/14] mini-os: headers for ARM Date: Wed, 16 Jul 2014 22:25:43 +0100 Message-ID: <53C6EDD7.1050105@linaro.org> References: <1405508874-3921-1-git-send-email-talex5@gmail.com> <1405508874-3921-5-git-send-email-talex5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X7Whw-0001MJ-Gb for xen-devel@lists.xenproject.org; Wed, 16 Jul 2014 21:25:48 +0000 Received: by mail-we0-f174.google.com with SMTP id x48so1563438wes.33 for ; Wed, 16 Jul 2014 14:25:47 -0700 (PDT) In-Reply-To: <1405508874-3921-5-git-send-email-talex5@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Thomas Leonard , xen-devel@lists.xenproject.org Cc: samuel.thibault@ens-lyon.org, stefano.stabellini@eu.citrix.com, David Scott , anil@recoil.org List-Id: xen-devel@lists.xenproject.org Hi Thomas, On 16/07/14 12:07, Thomas Leonard wrote: > diff --git a/extras/mini-os/include/arm/os.h b/extras/mini-os/include/arm/os.h > new file mode 100644 > index 0000000..6a1cc37 > --- /dev/null > +++ b/extras/mini-os/include/arm/os.h > @@ -0,0 +1,216 @@ > +#ifndef _OS_H_ > +#define _OS_H_ > + > +#ifndef __ASSEMBLY__ > + > +#include > +#include > +#include > +#include > +#include > + > +void arch_fini(void); > +void timer_handler(evtchn_port_t port, struct pt_regs *regs, void *ign); > + > +extern void *device_tree; > + > +#define BUG() while(1){asm volatile (".word 0xe7f000f0\n");} /* Undefined instruction; will call our fault handler. */ NIT: I would explain that ARM doesn't provide any undefined instruction so we use an encoding that is invalid on ARMv7. The other part of this patch looks good to me. FWIW: Acked-by: Julien Grall Regards, -- Julien Grall