building error

building error

[Wen Congyang]

I update qemu-xen-dir, and find this problem:

In file included from /usr/include/spice-server/spice.h:25:0,
                 from /work/src/xen/tools/qemu-xen-dir/include/ui/qemu-spice.h:25,
                 from qemu-char.c:84:
/usr/include/spice-1/spice/macros.h:105:0: error: "INLINE" redefined [-Werror]
 #define INLINE inline
 ^
In file included from /work/src/xen/tools/qemu-xen-dir/include/qemu/bswap.h:8:0,
                 from /work/src/xen/tools/qemu-xen-dir/include/qemu-common.h:112,
                 from qemu-char.c:24:
/work/src/xen/tools/qemu-xen-dir/include/fpu/softfloat.h:66:0: note: this is the location of the previous definition
 #define INLINE static inline
 ^
cc1: all warnings being treated as errors
  CC    page_cache.o

This problem has been fixed in upstream qemu:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a49db98d1f85ada0c4e5bb22bd93d541e7159c43

Re: building error

[Stefano Stabellini]

On Mon, 14 Jul 2014, Wen Congyang wrote:
> I update qemu-xen-dir, and find this problem:
> 
> In file included from /usr/include/spice-server/spice.h:25:0,
>                  from /work/src/xen/tools/qemu-xen-dir/include/ui/qemu-spice.h:25,
>                  from qemu-char.c:84:
> /usr/include/spice-1/spice/macros.h:105:0: error: "INLINE" redefined [-Werror]
>  #define INLINE inline
>  ^
> In file included from /work/src/xen/tools/qemu-xen-dir/include/qemu/bswap.h:8:0,
>                  from /work/src/xen/tools/qemu-xen-dir/include/qemu-common.h:112,
>                  from qemu-char.c:24:
> /work/src/xen/tools/qemu-xen-dir/include/fpu/softfloat.h:66:0: note: this is the location of the previous definition
>  #define INLINE static inline
>  ^
> cc1: all warnings being treated as errors
>   CC    page_cache.o
> 
> This problem has been fixed in upstream qemu:
> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a49db98d1f85ada0c4e5bb22bd93d541e7159c43
>

Thanks for the pointer. I cannot see this failure on my systems but the
backport should be harmless. I guess you would like a backport of both:

commit 37f6be977aefb5de8afe3ba62a95e88918381305
Author: Luiz Capitulino <lcapitulino@redhat.com>
Date:   Thu Jun 19 10:19:32 2014 -0400

    audio: fmopl: drop INLINE macro
        
and:

commit a49db98d1f85ada0c4e5bb22bd93d541e7159c43
Author: Luiz Capitulino <lcapitulino@redhat.com>
Date:   Thu Jun 19 10:13:43 2014 -0400

    fpu: softfloat: drop INLINE macro

correct?

Re: building error

[Wen Congyang]

At 2014/7/18 23:55, Stefano Stabellini Wrote:
> On Mon, 14 Jul 2014, Wen Congyang wrote:
>> I update qemu-xen-dir, and find this problem:
>>
>> In file included from /usr/include/spice-server/spice.h:25:0,
>>                   from /work/src/xen/tools/qemu-xen-dir/include/ui/qemu-spice.h:25,
>>                   from qemu-char.c:84:
>> /usr/include/spice-1/spice/macros.h:105:0: error: "INLINE" redefined [-Werror]
>>   #define INLINE inline
>>   ^
>> In file included from /work/src/xen/tools/qemu-xen-dir/include/qemu/bswap.h:8:0,
>>                   from /work/src/xen/tools/qemu-xen-dir/include/qemu-common.h:112,
>>                   from qemu-char.c:24:
>> /work/src/xen/tools/qemu-xen-dir/include/fpu/softfloat.h:66:0: note: this is the location of the previous definition
>>   #define INLINE static inline
>>   ^
>> cc1: all warnings being treated as errors
>>    CC    page_cache.o
>>
>> This problem has been fixed in upstream qemu:
>> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a49db98d1f85ada0c4e5bb22bd93d541e7159c43
>>
>
> Thanks for the pointer. I cannot see this failure on my systems but the
> backport should be harmless. I guess you would like a backport of both:

I build it on two systems: fc20 and rhel6. I only see this failure on fc20.

>
> commit 37f6be977aefb5de8afe3ba62a95e88918381305
> Author: Luiz Capitulino <lcapitulino@redhat.com>
> Date:   Thu Jun 19 10:19:32 2014 -0400
>
>      audio: fmopl: drop INLINE macro
>
> and:
>
> commit a49db98d1f85ada0c4e5bb22bd93d541e7159c43
> Author: Luiz Capitulino <lcapitulino@redhat.com>
> Date:   Thu Jun 19 10:13:43 2014 -0400
>
>      fpu: softfloat: drop INLINE macro
>
> correct?

Hmm, I only see the second failure. I guess it depends
on the builidng enviroment. But backporting both of them
is fine to me.

Thanks
Wen Congyang

>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>

building error

[Wen Congyang]

When I try to build xen on fc21, I meet the following errors:
drivers/net/ath/ath9k/ath9k_ar9003_phy.c: In function ‘ar9003_hw_ani_control’:
drivers/net/ath/ath9k/ath9k_ar9003_phy.c:862:11: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
   if (!on != aniState->ofdmWeakSigDetectOff) {
           ^
drivers/net/ath/ath9k/ath9k_ar9003_phy.c:1016:14: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
   if (!is_on != aniState->mrcCCKOff) {
              ^
cc1: all warnings being treated as errors
bin/rules/drivers/net/ath/ath9k/ath9k_ar9003_phy.c.r:3: recipe for target 'bin/ath9k_ar9003_phy.o' failed
make[7]: *** [bin/ath9k_ar9003_phy.o] Error 1
make[7]: *** Waiting for unfinished jobs....
  [BUILD] bin/nvsvpd.o
drivers/net/ath/ath9k/ath9k_ar5008_phy.c: In function ‘ar5008_hw_ani_control_old’:
drivers/net/ath/ath9k/ath9k_ar5008_phy.c:1144:11: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
   if (!on != aniState->ofdmWeakSigDetectOff) {
           ^
drivers/net/ath/ath9k/ath9k_ar5008_phy.c: In function ‘ar5008_hw_ani_control_new’:
drivers/net/ath/ath9k/ath9k_ar5008_phy.c:1310:11: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
   if (!on != aniState->ofdmWeakSigDetectOff) {
           ^
cc1: all warnings being treated as errors
bin/rules/drivers/net/ath/ath9k/ath9k_ar5008_phy.c.r:3: recipe for target 'bin/ath9k_ar5008_phy.o' failed
make[7]: *** [bin/ath9k_ar5008_phy.o] Error 1
make[7]: Leaving directory '/work/src/xen/tools/firmware/etherboot/ipxe/src'
Makefile:28: recipe for target 'ipxe/src/bin/rtl8139.rom' failed
make[6]: *** [ipxe/src/bin/rtl8139.rom] Error 2

I know my gcc has some problems, and will generate wrong bin file(We have discussed
it earlier).
But this building error is new problem. Do we have any plan to use newer ipxe?

I update ipxe to avoid the building error, and I meet the following error:
hw/virtio/virtio-rng.c: In function ‘virtio_rng_device_realize’:
hw/virtio/virtio-rng.c:152:31: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
     if (!vrng->conf.period_ms > 0) {
                               ^
cc1: all warnings being treated as errors

It seems that qemu have some problems.

Thanks
Wen Congyang

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel