From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wen Congyang <ghostwcy@gmail.com>
Subject: Re: building error
Date: Sat, 19 Jul 2014 00:27:30 +0800
Message-ID: <53C94AF2.2090402@gmail.com>
References: <53C37FF1.6040604@cn.fujitsu.com>
	<alpine.DEB.2.02.1407181652500.2295@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1407181652500.2295@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wen Congyang <wency@cn.fujitsu.com>
Cc: xen-devl <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

At 2014/7/18 23:55, Stefano Stabellini Wrote:
> On Mon, 14 Jul 2014, Wen Congyang wrote:
>> I update qemu-xen-dir, and find this problem:
>>
>> In file included from /usr/include/spice-server/spice.h:25:0,
>>                   from /work/src/xen/tools/qemu-xen-dir/include/ui/qemu-spice.h:25,
>>                   from qemu-char.c:84:
>> /usr/include/spice-1/spice/macros.h:105:0: error: "INLINE" redefined [-Werror]
>>   #define INLINE inline
>>   ^
>> In file included from /work/src/xen/tools/qemu-xen-dir/include/qemu/bswap.h:8:0,
>>                   from /work/src/xen/tools/qemu-xen-dir/include/qemu-common.h:112,
>>                   from qemu-char.c:24:
>> /work/src/xen/tools/qemu-xen-dir/include/fpu/softfloat.h:66:0: note: this is the location of the previous definition
>>   #define INLINE static inline
>>   ^
>> cc1: all warnings being treated as errors
>>    CC    page_cache.o
>>
>> This problem has been fixed in upstream qemu:
>> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=a49db98d1f85ada0c4e5bb22bd93d541e7159c43
>>
>
> Thanks for the pointer. I cannot see this failure on my systems but the
> backport should be harmless. I guess you would like a backport of both:

I build it on two systems: fc20 and rhel6. I only see this failure on fc20.

>
> commit 37f6be977aefb5de8afe3ba62a95e88918381305
> Author: Luiz Capitulino <lcapitulino@redhat.com>
> Date:   Thu Jun 19 10:19:32 2014 -0400
>
>      audio: fmopl: drop INLINE macro
>
> and:
>
> commit a49db98d1f85ada0c4e5bb22bd93d541e7159c43
> Author: Luiz Capitulino <lcapitulino@redhat.com>
> Date:   Thu Jun 19 10:13:43 2014 -0400
>
>      fpu: softfloat: drop INLINE macro
>
> correct?

Hmm, I only see the second failure. I guess it depends
on the builidng enviroment. But backporting both of them
is fine to me.

Thanks
Wen Congyang

>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>