From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH] libxl: create PVH guests with max memory assigned Date: Fri, 18 Jul 2014 19:00:42 +0200 Message-ID: <53C952BA.9020708@citrix.com> References: <1405594942-20760-1-git-send-email-roger.pau@citrix.com> <20140718164924.GA9514@laptop.dumpdata.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080306020700060308040109" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X8BWc-0003Zw-Ax for xen-devel@lists.xenproject.org; Fri, 18 Jul 2014 17:00:50 +0000 In-Reply-To: <20140718164924.GA9514@laptop.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org --------------080306020700060308040109 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 18/07/14 18:49, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 17, 2014 at 01:02:22PM +0200, Roger Pau Monne wrote: >> Since PVH guests are very similar to HVM guests in terms of memory >> management, start the guest with the maximum memory assigned and let >> it balloon down. > > There is something odd about your email. When I look at in > mutt I see the patch, but if I save it and try do git am > it complains. > > Looking at the file I see: > > U2luY2UgUFZIIGd1ZXN0cyBhcmUgdmVyeSBzaW1pbGFyIHRvIEhWTSBndWVzdHMgaW4gdGVybXMg > b2YgbWVtb3J5Cm1hbmFnZW1lbnQsIHN0YXJ0IHRoZSBndWVzdCB3aXRoIHRoZSBtYXhpbXVtIG1l > bW9yeSBhc3NpZ25lZCBhbmQgbGV0Cml0IGJhbGxvb24gZG93bi4KClNpZ25lZC1vZmYtYnk6IFJv > Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpDYzogSWFuIEphY2tzb24gPGlh > bi5qYWNrc29uQGV1LmNpdHJpeC5jb20+CkNjOiBJYW4gQ2FtcGJlbGwgPGlhbi5jYW1wYmVsbEBj > aXRyaXguY29tPgpDYzogTXVrZXNoIFJhdGhvciA8bXVrZXNoLnJhdGhvckBvcmFjbGUuY29tPgot > > .. and so. > > Have you changed something recently in your git sendmail setup? No, I haven't touched my git config since more than two years probably. Maybe Citrix smtp server is mangling it? Anyway, I'm attaching a copy, I hope you will be able to fetch it. Roger. --------------080306020700060308040109 Content-Type: text/plain; charset="UTF-8"; x-mac-type=0; x-mac-creator=0; name="0001-libxl-create-PVH-guests-with-max-memory-assigned.patch" Content-Length: 2776 Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-libxl-create-PVH-guests-with-max-memory-assigned.patch" >>From 59227b7a8fd3b891259a8a2b3154e17c3b5651d7 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Tue, 8 Jul 2014 10:35:20 +0200 Subject: [PATCH] libxl: create PVH guests with max memory assigned MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Since PVH guests are very similar to HVM guests in terms of memory management, start the guest with the maximum memory assigned and let it balloon down. Signed-off-by: Roger Pau Monn=C3=A9 Cc: Ian Jackson Cc: Ian Campbell Cc: Mukesh Rathor --- tools/libxl/libxl_dom.c | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index 661999c..eada87d 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -233,6 +233,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, libxl_domain_build_info *const info =3D &d_config->b_info; libxl_ctx *ctx =3D libxl__gc_owner(gc); char *xs_domid, *con_domid; + unsigned long mem; int rc; if (xc_domain_max_vcpus(ctx->xch, domid, info->max_vcpus) !=3D 0) { @@ -263,8 +264,12 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, libxl_domain_set_nodeaffinity(ctx, domid, &info->nodemap); libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus, &info->cpumap); - if (xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb + - LIBXL_MAXMEM_CONSTANT) < 0) { + if (info->type =3D=3D LIBXL_DOMAIN_TYPE_PV) + mem =3D libxl_defbool_val(d_config->c_info.pvh) =3F info->max_memkb : + info->target_memkb; + else + mem =3D info->target_memkb; + if (xc_domain_setmaxmem(ctx->xch, domid, mem + LIBXL_MAXMEM_CONSTANT) < 0) { LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "Couldn't set max memory"); return ERROR_FAIL; } @@ -370,6 +375,7 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid, { libxl_ctx *ctx =3D libxl__gc_owner(gc); struct xc_dom_image *dom; + unsigned long mem; int ret; int flags =3D 0; @@ -440,7 +446,8 @@ int libxl__build_pv(libxl__gc *gc, uint32_t domid, LOGE(ERROR, "libxl__arch_domain_init_hw_description failed"); goto out; } - if ( (ret =3D xc_dom_mem_init(dom, info->target_memkb / 1024)) !=3D 0 ) { + mem =3D state->pvh_enabled =3F info->max_memkb : info->target_memkb; + if ( (ret =3D xc_dom_mem_init(dom, mem / 1024)) !=3D 0 ) { LOGE(ERROR, "xc_dom_mem_init failed"); goto out; } -- 1.7.7.5 (Apple Git-26) --------------080306020700060308040109 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --------------080306020700060308040109--