From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 07/10] xen: arm: store per-boot module type instead of relying on index Date: Fri, 18 Jul 2014 21:52:48 +0100 Message-ID: <53C98920.7060606@linaro.org> References: <1405688876.491.10.camel@kazak.uk.xensource.com> <1405688900-11769-7-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1405688900-11769-7-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 18/07/14 14:08, Ian Campbell wrote: > This is more natural and better matches how multiboot is actually supposed to > work. > > As part of this we need to modify consider_modules to handle Xen not > necessarily being module zero any more. To do this we first register a module > for Xen at the original load address and then update after we have relocated. > This is also fixing a latent issue which is that get_xen_paddr() would not > consider Xen's current physical address when picking the target address which > was buggy because the relocation code cannot handle the possiblity of the old possibility > and new locations overlapping. > > All callers of consider_modules now consider the full range instead of some > skipping slot 0. > > Signed-off-by: Ian Campbell Acked-by: Julien Grall -- Julien Grall