From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v3 10/10] xen: arm: Only lookup kernel bootmodule once while building dom0 dtb.
Date: Fri, 18 Jul 2014 22:06:28 +0100 [thread overview]
Message-ID: <53C98C54.9040708@linaro.org> (raw)
In-Reply-To: <1405688900-11769-10-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 18/07/14 14:08, Ian Campbell wrote:
> diff --git a/xen/arch/arm/kernel.h b/xen/arch/arm/kernel.h
> index 7c7f624..2745bb5 100644
> --- a/xen/arch/arm/kernel.h
> +++ b/xen/arch/arm/kernel.h
> @@ -23,6 +23,7 @@ struct kernel_info {
> paddr_t entry;
>
> /* boot blob load addresses */
> + struct bootmodule *bootmodule;
If you don't read the assignment in the code you don't know to which
module the variable pointed to. I would rename to smth like kernelmodule.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-18 21:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 13:07 [PATCH v3 00/10] xen: arm: Refactor/improve early DT parsing and multiboot module support Ian Campbell
2014-07-18 13:08 ` [PATCH v3 01/10] xen: arm: implement generic multiboot compatibility strings Ian Campbell
2014-07-18 13:08 ` [PATCH v3 02/10] xen: arm: /chosen/module@N/bootargs bootprotcol node is not deprecated Ian Campbell
2014-07-18 13:08 ` [PATCH v3 03/10] xen: arm: prefer typesafe max()/min() over MAX()/MIN() Ian Campbell
2014-07-18 13:08 ` [PATCH v3 04/10] xen: arm: rename early_info structs Ian Campbell
2014-07-18 13:08 ` [PATCH v3 05/10] xen: arm: move boot time fdt parsing into separate file Ian Campbell
2014-07-18 13:08 ` [PATCH v3 06/10] xen: arm: move device_tree_bootargs to bootfdt.c, renaming to boot_fdt_cmdline Ian Campbell
2014-07-18 13:08 ` [PATCH v3 07/10] xen: arm: store per-boot module type instead of relying on index Ian Campbell
2014-07-18 20:52 ` Julien Grall
2014-07-18 13:08 ` [PATCH v3 08/10] xen: arm: support bootmodule type detection by ordering Ian Campbell
2014-07-18 21:02 ` Julien Grall
2014-07-21 10:18 ` Ian Campbell
2014-07-18 13:08 ` [PATCH v3 09/10] xen: arm: update multiboot device tree bindings Ian Campbell
2014-07-18 21:03 ` Julien Grall
2014-07-21 11:45 ` Ian Campbell
2014-07-21 11:53 ` Julien Grall
2014-07-21 12:18 ` Ian Campbell
2014-07-21 12:23 ` Julien Grall
2014-07-21 12:26 ` Ian Campbell
2014-07-21 12:34 ` Julien Grall
2014-07-24 14:30 ` Ian Campbell
2014-07-24 14:33 ` Julien Grall
2014-07-24 15:12 ` Ian Campbell
2014-07-18 13:08 ` [PATCH v3 10/10] xen: arm: Only lookup kernel bootmodule once while building dom0 dtb Ian Campbell
2014-07-18 21:06 ` Julien Grall [this message]
2014-07-21 10:20 ` Ian Campbell
2014-07-21 11:48 ` [PATCH v3 00/10] xen: arm: Refactor/improve early DT parsing and multiboot module support Ian Campbell
2014-07-22 3:20 ` Fu Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C98C54.9040708@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).