From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 10/10] xen: arm: Only lookup kernel
 bootmodule once while building dom0 dtb.
Date: Fri, 18 Jul 2014 22:06:28 +0100
Message-ID: <53C98C54.9040708@linaro.org>
References: <1405688876.491.10.camel@kazak.uk.xensource.com>
	<1405688900-11769-10-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1405688900-11769-10-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 18/07/14 14:08, Ian Campbell wrote:
> diff --git a/xen/arch/arm/kernel.h b/xen/arch/arm/kernel.h
> index 7c7f624..2745bb5 100644
> --- a/xen/arch/arm/kernel.h
> +++ b/xen/arch/arm/kernel.h
> @@ -23,6 +23,7 @@ struct kernel_info {
>       paddr_t entry;
>
>       /* boot blob load addresses */
> +    struct bootmodule *bootmodule;

If you don't read the assignment in the code you don't know to which 
module the variable pointed to. I would rename to smth like kernelmodule.

Regards,

-- 
Julien Grall