xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Ian Jackson <ian.jackson@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH 2/5] make: Normalize config options for external trees
Date: Mon, 21 Jul 2014 11:28:02 +0100	[thread overview]
Message-ID: <53CCEB32.80208@eu.citrix.com> (raw)
In-Reply-To: <20140721102235.GA8522@aepfle.de>

On 07/21/2014 11:22 AM, Olaf Hering wrote:
> On Mon, Jul 14, George Dunlap wrote:
>
>>   - CONFIG_QEMU          (=> QEMU_TRADITIONAL_LOC)
>>   - QEMU_REMOTE          (=> QEMU_TRADITIONAL_URL)
>>   - QEMU_TAG             (=> QEMU_TRADITIONAL_REVISION)
>>   - SEABIOS_UPSTREAM_TAG (=> SEABIOS_UPSTREAM_REVISION)
> This broke my script, which I fixed just now.

How did it break your script?  The intent was that it would be 
backwards-compatible enough not to break anyone's scripts...

> And I think the patch missed ipxe:
> tools/firmware/etherboot/Makefile:IPXE_GIT_TAG := 9a93db3f0947484e30e753bbd61a10b17336e20e

Hmm, so this should probably be moved into Config.mk.

  -George

  reply	other threads:[~2014-07-21 10:28 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 16:15 [PATCH 1/5] make: Check tools/qemu-xen[-traditional] for qemu before downloading George Dunlap
2014-07-14 16:15 ` [PATCH 2/5] make: Normalize config options for external trees George Dunlap
2014-07-16  8:58   ` Ian Campbell
2014-07-16 14:53   ` Ian Jackson
2014-07-21 10:22   ` Olaf Hering
2014-07-21 10:28     ` George Dunlap [this message]
2014-07-21 10:44       ` Olaf Hering
2014-07-21 10:46         ` George Dunlap
2014-07-21 10:49       ` Olaf Hering
2014-07-14 16:15 ` [PATCH 3/5] make: Make *-dir-force-update depend on *-dir-find George Dunlap
2014-07-16 14:53   ` Ian Jackson
2014-07-14 16:15 ` [PATCH 4/5] make: Add subtree-update target George Dunlap
2014-07-16  9:00   ` Ian Campbell
2014-07-16 14:54   ` Ian Jackson
2014-07-14 16:15 ` [PATCH 5/5] make: Make "src-tarball" target actually make a source tarball George Dunlap
2014-07-16 15:06   ` Ian Jackson
2014-07-16 16:56     ` Ian Campbell
2014-07-16 17:45       ` George Dunlap
2014-07-17  9:21         ` Ian Campbell
2014-07-17 16:46     ` George Dunlap
2014-07-18 10:45       ` Ian Jackson
2014-09-15 15:42       ` George Dunlap
2014-09-15 15:46         ` Ian Jackson
2014-07-16  9:02 ` [PATCH 1/5] make: Check tools/qemu-xen[-traditional] for qemu before downloading Ian Campbell
2014-07-16 14:50 ` Ian Jackson
2014-07-18 12:39 ` Ian Campbell
2014-07-23 10:52 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CCEB32.80208@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@citrix.com \
    --cc=olaf@aepfle.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).