From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 2/5] make: Normalize config options for external trees Date: Mon, 21 Jul 2014 11:28:02 +0100 Message-ID: <53CCEB32.80208@eu.citrix.com> References: <1405354526-20929-1-git-send-email-george.dunlap@eu.citrix.com> <1405354526-20929-2-git-send-email-george.dunlap@eu.citrix.com> <20140721102235.GA8522@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140721102235.GA8522@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Ian Jackson , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/21/2014 11:22 AM, Olaf Hering wrote: > On Mon, Jul 14, George Dunlap wrote: > >> - CONFIG_QEMU (=> QEMU_TRADITIONAL_LOC) >> - QEMU_REMOTE (=> QEMU_TRADITIONAL_URL) >> - QEMU_TAG (=> QEMU_TRADITIONAL_REVISION) >> - SEABIOS_UPSTREAM_TAG (=> SEABIOS_UPSTREAM_REVISION) > This broke my script, which I fixed just now. How did it break your script? The intent was that it would be backwards-compatible enough not to break anyone's scripts... > And I think the patch missed ipxe: > tools/firmware/etherboot/Makefile:IPXE_GIT_TAG := 9a93db3f0947484e30e753bbd61a10b17336e20e Hmm, so this should probably be moved into Config.mk. -George