From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v7 1/5] xen/arm: Add support for GIC v3 Date: Tue, 22 Jul 2014 11:01:40 +0100 Message-ID: <53CE3684.9040106@linaro.org> References: <1405083092-20216-1-git-send-email-vijay.kilari@gmail.com> <1405083092-20216-2-git-send-email-vijay.kilari@gmail.com> <1405510909.7019.86.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vijay Kilari , Ian Campbell Cc: Stefano Stabellini , Prasun Kapoor , Vijaya Kumar K , Tim Deegan , "xen-devel@lists.xen.org" , Stefano Stabellini , manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 22/07/14 10:48, Vijay Kilari wrote: >>> +/* >>> + * Additional registers defined in GIC v3. >>> + * Common GICD registers are defined in gic.h >>> + */ >>> + >>> +#define GICD_STATUSR (0x010) >>> [...][ >>> +#define GICV3_GICD_PIDR0 (0x92) >> >> What is the distinction between variables with GIC[DR]_ prefixes and >> those with GICV3_GIC[DR]_ ones? > > GICV3 is prefixed for indicating that there are values not the addresses. > In anycase I will remove GICV3 prefixes and postfix _VAL Those value are GICV3 specific. If you drop the prefix we won't know what are their purpose... -- Julien Grall