From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [RFC PATCH 2/2] xen/arm: introduce XENFEAT_grant_map_11 Date: Wed, 23 Jul 2014 12:17:48 +0100 Message-ID: <53CFB5FC02000078000250C0@mail.emea.novell.com> References: <1404834794-16055-2-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X9uYT-0003Xk-5g for xen-devel@lists.xenproject.org; Wed, 23 Jul 2014 11:17:53 +0000 In-Reply-To: <1404834794-16055-2-git-send-email-stefano.stabellini@eu.citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: julien.grall@citrix.com, xen-devel , Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org >>> On 08.07.14 at 17:53, wrote: > --- a/xen/common/kernel.c > +++ b/xen/common/kernel.c > @@ -325,6 +325,10 @@ DO(xen_version)(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > break; > } > #endif > +#ifdef CONFIG_ARM > + if ( is_domain_direct_mapped(d) ) The #ifdef and if() seem kind of redundant - can't x86 simply get a stub always returning false? > --- a/xen/include/asm-arm/grant_table.h > +++ b/xen/include/asm-arm/grant_table.h > @@ -33,8 +33,7 @@ static inline int replace_grant_supported(void) > ( ((i >= nr_grant_frames(d->grant_table)) && \ > (i < max_nr_grant_frames)) ? 0 : (d->arch.grant_table_gpfn[i])) > > -#define gnttab_need_iommu_mapping(d) \ > - (is_domain_direct_mapped(d) && need_iommu(d)) > +#define gnttab_need_iommu_mapping(d) (is_domain_direct_mapped(d)) How is this change related to the subject of the patch? > --- a/xen/include/public/features.h > +++ b/xen/include/public/features.h > @@ -94,6 +94,9 @@ > /* operation as Dom0 is supported */ > #define XENFEAT_dom0 11 > > +/* Xen also maps grant references at pfn = mfn */ > +#define XENFEAT_grant_map_11 12 As already said by others, this needs a better name. Jan