xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@eu.citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel@lists.xenproject.org
Cc: JBeulich@suse.com, julien.grall@linaro.org,
	Ian.Campbell@citrix.com, anup.patel@linaro.org,
	pranavkumar@linaro.org
Subject: Re: [PATCH v2 1/2] xen: export do_yield as vcpu_yield
Date: Wed, 23 Jul 2014 14:43:53 +0100	[thread overview]
Message-ID: <53CFBC19.1050304@eu.citrix.com> (raw)
In-Reply-To: <1406122643-12028-1-git-send-email-stefano.stabellini@eu.citrix.com>

On 07/23/2014 02:37 PM, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> CC: george.dunlap@eu.citrix.com
> CC: JBeulich@suse.com

Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

>
> Changes in v2:
> - do not change paramters and return value of do_yield.
> ---
>   xen/common/schedule.c   |    6 +++---
>   xen/include/xen/sched.h |    1 +
>   2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/xen/common/schedule.c b/xen/common/schedule.c
> index e9eb0bc..9a49769 100644
> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -795,7 +795,7 @@ static long do_poll(struct sched_poll *sched_poll)
>   }
>   
>   /* Voluntarily yield the processor for this allocation. */
> -static long do_yield(void)
> +long vcpu_yield(void)
>   {
>       struct vcpu * v=current;
>       spinlock_t *lock = vcpu_schedule_lock_irq(v);
> @@ -888,7 +888,7 @@ long do_sched_op_compat(int cmd, unsigned long arg)
>       {
>       case SCHEDOP_yield:
>       {
> -        ret = do_yield();
> +        ret = vcpu_yield();
>           break;
>       }
>   
> @@ -925,7 +925,7 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg)
>       {
>       case SCHEDOP_yield:
>       {
> -        ret = do_yield();
> +        ret = vcpu_yield();
>           break;
>       }
>   
> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
> index 2f876f5..be932cf 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -634,6 +634,7 @@ int  sched_id(void);
>   void sched_tick_suspend(void);
>   void sched_tick_resume(void);
>   void vcpu_wake(struct vcpu *v);
> +long vcpu_yield(void);
>   void vcpu_sleep_nosync(struct vcpu *v);
>   void vcpu_sleep_sync(struct vcpu *v);
>   

  reply	other threads:[~2014-07-23 13:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 13:35 [PATCH v2 0/2] xen/arm: vcpu_yield on WFE Stefano Stabellini
2014-07-23 13:37 ` [PATCH v2 1/2] xen: export do_yield as vcpu_yield Stefano Stabellini
2014-07-23 13:43   ` George Dunlap [this message]
2014-07-23 13:37 ` [PATCH v2 2/2] xen/arm: call vcpu_yield on WFE trap Stefano Stabellini
2014-07-23 16:11 ` [PATCH v2 0/2] xen/arm: vcpu_yield on WFE Julien Grall
2014-07-23 16:21   ` Stefano Stabellini
2014-07-23 16:33     ` Julien Grall
2014-07-23 18:12       ` Julien Grall
2014-07-28 12:46 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CFBC19.1050304@eu.citrix.com \
    --to=george.dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=anup.patel@linaro.org \
    --cc=julien.grall@linaro.org \
    --cc=pranavkumar@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).