From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v8 3/7] xen/arm: Add support for GIC v3
Date: Wed, 23 Jul 2014 18:28:26 +0100
Message-ID: <53CFF0BA.40705@linaro.org>
References: <1406122913-8303-1-git-send-email-vijay.kilari@gmail.com>
	<1406122913-8303-4-git-send-email-vijay.kilari@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1406122913-8303-4-git-send-email-vijay.kilari@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: vijay.kilari@gmail.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, jbeulich@suse.com, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

Hi Vijay,

On 07/23/2014 02:41 PM, vijay.kilari@gmail.com wrote:
> +#define GICD_PIDR2_ARCH_REV_MASK     (0xf0)
> +#define GICD_PIDR2_ARCH_REV_OFFSET   (0x4)

NIT: We tend to use SHIFT rather than OFFSET.

> +#define GICD_PIDR2_ARCH_GICV3        (0x3)
> +#define GICD_PIDR2_USES_JEP_MASK     (0x08)
> +#define GICD_PIDR2_JEP_ID_MASK       (0x07)

NIT: I don't see any usage of GICD_PIDR2_USES_JEP_MASK and
GICD_PIDR2_JEP_ID_MASK.

Hence, you don't define the SHIFT. So I would drop them.

Regards,

-- 
Julien Grall