From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v8 3/7] xen/arm: Add support for GIC v3 Date: Thu, 24 Jul 2014 11:26:40 +0100 Message-ID: <53D0DF60.9090705@linaro.org> References: <1406122913-8303-1-git-send-email-vijay.kilari@gmail.com> <1406122913-8303-4-git-send-email-vijay.kilari@gmail.com> <53CFF0BA.40705@linaro.org> <1406192612.23159.5.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1406192612.23159.5.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On 24/07/14 10:03, Ian Campbell wrote: > On Wed, 2014-07-23 at 18:28 +0100, Julien Grall wrote: >> Hi Vijay, >> >> On 07/23/2014 02:41 PM, vijay.kilari@gmail.com wrote: >>> +#define GICD_PIDR2_ARCH_REV_MASK (0xf0) >>> +#define GICD_PIDR2_ARCH_REV_OFFSET (0x4) >> >> NIT: We tend to use SHIFT rather than OFFSET. >> >>> +#define GICD_PIDR2_ARCH_GICV3 (0x3) >>> +#define GICD_PIDR2_USES_JEP_MASK (0x08) >>> +#define GICD_PIDR2_JEP_ID_MASK (0x07) >> >> NIT: I don't see any usage of GICD_PIDR2_USES_JEP_MASK and >> GICD_PIDR2_JEP_ID_MASK. >> >> Hence, you don't define the SHIFT. So I would drop them. > > FWIW I don't think it is a problem define bits of a register which > aren't currently used on the principal that including the full set is a > reasonable choice. In this case, he has to be consistent and also define the SHIFT. It's pointless to only define a MASK. Regards, -- Julien Grall