* [PATCH] xen: arm: ignore CPUs which are not marked available in the DT
@ 2014-07-23 16:45 Ian Campbell
2014-07-23 17:15 ` Julien Grall
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2014-07-23 16:45 UTC (permalink / raw)
To: xen-devel; +Cc: julien.grall, tim, Ian Campbell, stefano.stabellini
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/smpboot.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index cf149da..4b0a738 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -134,6 +134,9 @@ void __init smp_init_cpus(void)
if ( !dt_device_type_is_equal(cpu, "cpu") )
continue;
+ if ( !dt_device_is_available(cpu) )
+ continue;
+
if ( dt_n_size_cells(cpu) != 0 )
printk(XENLOG_WARNING "cpu node `%s`: #size-cells %d\n",
dt_node_full_name(cpu), dt_n_size_cells(cpu));
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xen: arm: ignore CPUs which are not marked available in the DT
2014-07-23 16:45 [PATCH] xen: arm: ignore CPUs which are not marked available in the DT Ian Campbell
@ 2014-07-23 17:15 ` Julien Grall
2014-07-23 18:36 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2014-07-23 17:15 UTC (permalink / raw)
To: Ian Campbell, xen-devel; +Cc: tim, stefano.stabellini
Hi Ian,
On 07/23/2014 05:45 PM, Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> xen/arch/arm/smpboot.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index cf149da..4b0a738 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -134,6 +134,9 @@ void __init smp_init_cpus(void)
> if ( !dt_device_type_is_equal(cpu, "cpu") )
> continue;
>
> + if ( !dt_device_is_available(cpu) )
> + continue;
> +
I can't find a such things on the Linux device tree bindings. Do you
have a use case where CPU are marked disabled?
Regards,
> if ( dt_n_size_cells(cpu) != 0 )
> printk(XENLOG_WARNING "cpu node `%s`: #size-cells %d\n",
> dt_node_full_name(cpu), dt_n_size_cells(cpu));
>
--
Julien Grall
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen: arm: ignore CPUs which are not marked available in the DT
2014-07-23 17:15 ` Julien Grall
@ 2014-07-23 18:36 ` Ian Campbell
2014-07-24 10:36 ` Julien Grall
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2014-07-23 18:36 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Wed, 2014-07-23 at 18:15 +0100, Julien Grall wrote:
> Hi Ian,
>
> On 07/23/2014 05:45 PM, Ian Campbell wrote:
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > ---
> > xen/arch/arm/smpboot.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> > index cf149da..4b0a738 100644
> > --- a/xen/arch/arm/smpboot.c
> > +++ b/xen/arch/arm/smpboot.c
> > @@ -134,6 +134,9 @@ void __init smp_init_cpus(void)
> > if ( !dt_device_type_is_equal(cpu, "cpu") )
> > continue;
> >
> > + if ( !dt_device_is_available(cpu) )
> > + continue;
> > +
>
> I can't find a such things on the Linux device tree bindings.
status is a generic property which is common to all nodes, it comes from
ePAPR.
> Do you
> have a use case where CPU are marked disabled?
I use it locally when booting with models -- it allows me to turn off
cpus in the base .dts file using a wrapper instead of having to edit the
original.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen: arm: ignore CPUs which are not marked available in the DT
2014-07-23 18:36 ` Ian Campbell
@ 2014-07-24 10:36 ` Julien Grall
2014-07-24 10:40 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2014-07-24 10:36 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
Hi Ian,
On 23/07/14 19:36, Ian Campbell wrote:
> On Wed, 2014-07-23 at 18:15 +0100, Julien Grall wrote:
>> On 07/23/2014 05:45 PM, Ian Campbell wrote:
>>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>> ---
>>> xen/arch/arm/smpboot.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
>>> index cf149da..4b0a738 100644
>>> --- a/xen/arch/arm/smpboot.c
>>> +++ b/xen/arch/arm/smpboot.c
>>> @@ -134,6 +134,9 @@ void __init smp_init_cpus(void)
>>> if ( !dt_device_type_is_equal(cpu, "cpu") )
>>> continue;
>>>
>>> + if ( !dt_device_is_available(cpu) )
>>> + continue;
>>> +
>>
>> I can't find a such things on the Linux device tree bindings.
>
> status is a generic property which is common to all nodes, it comes from
> ePAPR.
>
>> Do you
>> have a use case where CPU are marked disabled?
>
> I use it locally when booting with models -- it allows me to turn off
> cpus in the base .dts file using a wrapper instead of having to edit the
> original.
I read the ePAPR and the property status on CPU node. AFAIU, the
property doesn't have this meaning for a such node.
This property means the CPU is in quiescent state and property to bring
up the CPU is provides in the device tree node.
Section 5.5.2.2:
Before starting a client program on the boot cpu, the boot program shall
set certain properties in the
device tree passed to the client as follows:
• Each secondary CPU’s cpu node shall have a status property with a
value of “disabled”.
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen: arm: ignore CPUs which are not marked available in the DT
2014-07-24 10:36 ` Julien Grall
@ 2014-07-24 10:40 ` Ian Campbell
2014-07-24 10:44 ` Julien Grall
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2014-07-24 10:40 UTC (permalink / raw)
To: Julien Grall; +Cc: stefano.stabellini, tim, xen-devel
On Thu, 2014-07-24 at 11:36 +0100, Julien Grall wrote:
> Hi Ian,
>
> On 23/07/14 19:36, Ian Campbell wrote:
> > On Wed, 2014-07-23 at 18:15 +0100, Julien Grall wrote:
> >> On 07/23/2014 05:45 PM, Ian Campbell wrote:
> >>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> >>> ---
> >>> xen/arch/arm/smpboot.c | 3 +++
> >>> 1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> >>> index cf149da..4b0a738 100644
> >>> --- a/xen/arch/arm/smpboot.c
> >>> +++ b/xen/arch/arm/smpboot.c
> >>> @@ -134,6 +134,9 @@ void __init smp_init_cpus(void)
> >>> if ( !dt_device_type_is_equal(cpu, "cpu") )
> >>> continue;
> >>>
> >>> + if ( !dt_device_is_available(cpu) )
> >>> + continue;
> >>> +
> >>
> >> I can't find a such things on the Linux device tree bindings.
> >
> > status is a generic property which is common to all nodes, it comes from
> > ePAPR.
> >
> >> Do you
> >> have a use case where CPU are marked disabled?
> >
> > I use it locally when booting with models -- it allows me to turn off
> > cpus in the base .dts file using a wrapper instead of having to edit the
> > original.
>
> I read the ePAPR and the property status on CPU node. AFAIU, the
> property doesn't have this meaning for a such node.
>
> This property means the CPU is in quiescent state and property to bring
> up the CPU is provides in the device tree node.
>
> Section 5.5.2.2:
>
> Before starting a client program on the boot cpu, the boot program shall
> set certain properties in the
> device tree passed to the client as follows:
> • Each secondary CPU’s cpu node shall have a status property with a
> value of “disabled”.
Oh well, it was only a convenience for me anyway.
Ian
>
> Regards,
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen: arm: ignore CPUs which are not marked available in the DT
2014-07-24 10:40 ` Ian Campbell
@ 2014-07-24 10:44 ` Julien Grall
0 siblings, 0 replies; 6+ messages in thread
From: Julien Grall @ 2014-07-24 10:44 UTC (permalink / raw)
To: Ian Campbell; +Cc: stefano.stabellini, tim, xen-devel
On 24/07/14 11:40, Ian Campbell wrote:
> On Thu, 2014-07-24 at 11:36 +0100, Julien Grall wrote:
>> Hi Ian,
>>
>> On 23/07/14 19:36, Ian Campbell wrote:
>>> On Wed, 2014-07-23 at 18:15 +0100, Julien Grall wrote:
>>>> On 07/23/2014 05:45 PM, Ian Campbell wrote:
>>>>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>>>>> ---
>>>>> xen/arch/arm/smpboot.c | 3 +++
>>>>> 1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
>>>>> index cf149da..4b0a738 100644
>>>>> --- a/xen/arch/arm/smpboot.c
>>>>> +++ b/xen/arch/arm/smpboot.c
>>>>> @@ -134,6 +134,9 @@ void __init smp_init_cpus(void)
>>>>> if ( !dt_device_type_is_equal(cpu, "cpu") )
>>>>> continue;
>>>>>
>>>>> + if ( !dt_device_is_available(cpu) )
>>>>> + continue;
>>>>> +
>>>>
>>>> I can't find a such things on the Linux device tree bindings.
>>>
>>> status is a generic property which is common to all nodes, it comes from
>>> ePAPR.
>>>
>>>> Do you
>>>> have a use case where CPU are marked disabled?
>>>
>>> I use it locally when booting with models -- it allows me to turn off
>>> cpus in the base .dts file using a wrapper instead of having to edit the
>>> original.
>>
>> I read the ePAPR and the property status on CPU node. AFAIU, the
>> property doesn't have this meaning for a such node.
>>
>> This property means the CPU is in quiescent state and property to bring
>> up the CPU is provides in the device tree node.
>>
>> Section 5.5.2.2:
>>
>> Before starting a client program on the boot cpu, the boot program shall
>> set certain properties in the
>> device tree passed to the client as follows:
>> • Each secondary CPU’s cpu node shall have a status property with a
>> value of “disabled”.
>
> Oh well, it was only a convenience for me anyway.
> Ian
Could we add a property xen,status for debugging (i.e when Xen is
compiled with debug=y)? So we don't collapse with the actual property if
someone decide to implement it in the bootloader.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-24 10:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-23 16:45 [PATCH] xen: arm: ignore CPUs which are not marked available in the DT Ian Campbell
2014-07-23 17:15 ` Julien Grall
2014-07-23 18:36 ` Ian Campbell
2014-07-24 10:36 ` Julien Grall
2014-07-24 10:40 ` Ian Campbell
2014-07-24 10:44 ` Julien Grall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).