From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 1/3] xen/x86: introduce is_domain_direct_mapped(d) as (0) on x86 Date: Thu, 24 Jul 2014 14:41:26 +0100 Message-ID: <53D10D06.6070808@linaro.org> References: <1406208666-23547-1-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1406208666-23547-1-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , xen-devel@lists.xensource.com Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 07/24/2014 02:31 PM, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini > --- > xen/include/asm-x86/domain.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h > index abf55fb..5f9354b 100644 > --- a/xen/include/asm-x86/domain.h > +++ b/xen/include/asm-x86/domain.h > @@ -19,6 +19,7 @@ > #define is_hvm_pv_evtchn_domain(d) (has_hvm_container_domain(d) && \ > d->arch.hvm_domain.irq.callback_via_type == HVMIRQ_callback_vector) > #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain)) > +#define is_domain_direct_mapped(d) (0) When I've implemented this defined in common/memory.c, Jan told me to use [1]: #define is_domain_is_direct_mapped(d) ((void)(d), 0) I suspect you want the same things here. Also, could you drop the define in common/memory.c. I don't think it's useful now. > #define VCPU_TRAP_NMI 1 > #define VCPU_TRAP_MCE 2 > Regards, [1] https://patches.linaro.org/22523/ -- Julien Grall