From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 09/10] xen: arm: update multiboot device tree bindings. Date: Thu, 24 Jul 2014 15:33:32 +0100 Message-ID: <53D1193C.9040709@linaro.org> References: <1405688876.491.10.camel@kazak.uk.xensource.com> <1405688900-11769-9-git-send-email-ian.campbell@citrix.com> <53C98BB4.5070302@linaro.org> <1405943128.25022.37.camel@kazak.uk.xensource.com> <53CCFF1C.10607@linaro.org> <1405945096.25022.46.camel@kazak.uk.xensource.com> <53CD0643.4010600@linaro.org> <1405945584.25022.51.camel@kazak.uk.xensource.com> <53CD08CB.1040403@linaro.org> <1406212225.24167.4.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1406212225.24167.4.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/24/2014 03:30 PM, Ian Campbell wrote: > On Mon, 2014-07-21 at 13:34 +0100, Julien Grall wrote: >>>>> From f9e80ead57b9f739c3041fe5abc4b23c8f0eb18f Mon Sep 17 00:00:00 2001 >>>>> From: Ian Campbell >>>>> Date: Mon, 21 Jul 2014 13:16:31 +0100 >>>>> Subject: [PATCH] xen: arm: document boot module compatibility based on >>>>> ordering >>>>> >>>>> Signed-off-by: Ian Campbell >>>>> --- >>>>> docs/misc/arm/device-tree/booting.txt | 8 +++++++- >>>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt >>>>> index d967061..ad98bf3 100644 >>>>> --- a/docs/misc/arm/device-tree/booting.txt >>>>> +++ b/docs/misc/arm/device-tree/booting.txt >>>>> @@ -23,7 +23,13 @@ Each node contains the following properties: >>>>> compatible string (if one applies) in addition to the generic >>>>> string (which must always be present). >>>>> >>>>> - Xen 4.4 supported a different set of legacy compatible strings >>>>> + Xen will assume that the first module which lacks a more >>>> >>>> With this change, it's not clear that Xen 4.4 doesn't support boot >>>> module ordering. I would precise Xen 4.5 and onwards. >>> >>> Note that a paragraph further down still reads: >>> For compatibility with Xen 4.4 the more specific "xen,linux-*" >>> names are non-optional and must be included. >> >> Oh right, I forgot there was a paragraph about it. >> >> So this change looks good to me. > > May I take that as an Ack? I though have acked it on a previous mail... Anyway: Acked-by: Julien Grall Regards, -- Julien Grall