From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen: arm: Correct comment in arm32 head.S
Date: Fri, 25 Jul 2014 13:10:23 +0100 [thread overview]
Message-ID: <53D2492F.3060706@linaro.org> (raw)
In-Reply-To: <c7200cac67169527cd2fff3b8b553c74edb1e1ee.1406280732.git.ian.campbell@citrix.com>
Hi Ian,
On 07/25/2014 10:32 AM, Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Julien Grall <julien.grall@linaro.org>
Regards,
> ---
> xen/arch/arm/arm32/head.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index ec57974..16d76f4 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -378,7 +378,7 @@ paging:
> 1:
>
> /* Map fixmap into boot_second */
> - ldr r1, =boot_second /* r1 := vaddr (xen_fixmap) */
> + ldr r1, =boot_second /* r1 := vaddr (boot_second) */
> ldr r2, =xen_fixmap
> add r2, r2, r10 /* r2 := paddr (xen_fixmap) */
> orr r2, r2, #PT_UPPER(PT)
>
--
Julien Grall
next prev parent reply other threads:[~2014-07-25 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 9:32 [PATCH] xen: arm: Correct comment in arm32 head.S Ian Campbell
2014-07-25 12:10 ` Julien Grall [this message]
2014-09-08 20:48 ` Julien Grall
2014-09-09 9:22 ` Ian Campbell
2014-09-09 18:12 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D2492F.3060706@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).