Re: [PATCH v4 1/3] xen/x86: introduce is_domain_direct_mapped(d) as ((void)(d), 0) on x86

["Jan Beulich" <JBeulich@suse.com>]

>>> On 28.07.14 at 12:16, <stefano.stabellini@eu.citrix.com> wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

> ---
> 
> Changes in v4:
> - remove define is_domain_direct_mapped in common/memory.c;
> - define is_domain_direct_mapped as ((void)(d), 0)
> ---
>  xen/common/memory.c          |    4 ----
>  xen/include/asm-x86/domain.h |    1 +
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/xen/common/memory.c b/xen/common/memory.c
> index c2dd31b..d69976f 100644
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -29,10 +29,6 @@
>  #include <xsm/xsm.h>
>  #include <xen/trace.h>
>  
> -#ifndef is_domain_direct_mapped
> -# define is_domain_direct_mapped(d) ((void)(d), 0)
> -#endif
> -
>  struct memop_args {
>      /* INPUT */
>      struct domain *domain;     /* Domain to be affected. */
> diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
> index abf55fb..59a28ba 100644
> --- a/xen/include/asm-x86/domain.h
> +++ b/xen/include/asm-x86/domain.h
> @@ -19,6 +19,7 @@
>  #define is_hvm_pv_evtchn_domain(d) (has_hvm_container_domain(d) && \
>          d->arch.hvm_domain.irq.callback_via_type == HVMIRQ_callback_vector)
>  #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain))
> +#define is_domain_direct_mapped(d) ((void)(d), 0)
>  
>  #define VCPU_TRAP_NMI          1
>  #define VCPU_TRAP_MCE          2
> -- 
> 1.7.10.4