From: David Vrabel <david.vrabel@citrix.com>
To: Matt Rushton <mvrushton@gmail.com>,
konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
Cc: msw@amazon.com, linux-kernel@vger.kernel.org,
xen-devel@lists.xensource.com, Matt Rushton <mrushton@amazon.com>
Subject: Re: [PATCH v2 1/2] xen/setup: Remove Identity Map Debug Message
Date: Mon, 28 Jul 2014 14:14:29 +0100 [thread overview]
Message-ID: <53D64CB5.4070703@citrix.com> (raw)
In-Reply-To: <1405814495-10868-1-git-send-email-mrushton@amazon.com>
On 20/07/14 01:01, Matt Rushton wrote:
> Removing a debug message for setting the identity map since it becomes
> rather noisy after rework of the identity map code.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
> --- a/arch/x86/xen/p2m.c
> +++ b/arch/x86/xen/p2m.c
> @@ -841,10 +841,9 @@ unsigned long __init set_phys_range_identity(unsigned long pfn_s,
> pfn = ALIGN(pfn, P2M_PER_PAGE);
> }
>
> - if (!WARN((pfn - pfn_s) != (pfn_e - pfn_s),
> + WARN((pfn - pfn_s) != (pfn_e - pfn_s),
> "Identity mapping failed. We are %ld short of 1-1 mappings!\n",
> - (pfn_e - pfn_s) - (pfn - pfn_s)))
> - printk(KERN_DEBUG "1-1 mapping on %lx->%lx\n", pfn_s, pfn);
> + (pfn_e - pfn_s) - (pfn - pfn_s));
>
> return pfn - pfn_s;
> }
>
prev parent reply other threads:[~2014-07-28 13:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 0:01 [PATCH v2 1/2] xen/setup: Remove Identity Map Debug Message Matt Rushton
2014-07-20 0:01 ` [PATCH v2 2/2] xen/setup: Remap Xen Identity Mapped RAM Matt Rushton
2014-07-28 13:18 ` David Vrabel
2014-07-31 17:43 ` David Vrabel
2014-08-01 14:52 ` David Vrabel
2014-08-01 15:52 ` Matt Wilson
2014-08-01 15:56 ` Boris Ostrovsky
2014-08-02 0:52 ` Matthew Rushton
2014-08-11 17:40 ` Matthew Rushton
2014-08-26 20:40 ` Matthew Rushton
2014-07-28 13:14 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D64CB5.4070703@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrushton@amazon.com \
--cc=msw@amazon.com \
--cc=mvrushton@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).