xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH v5 3/3] xen/arm: introduce XENFEAT_grant_map_identity
Date: Mon, 28 Jul 2014 16:52:37 +0100	[thread overview]
Message-ID: <53D671C5.906@linaro.org> (raw)
In-Reply-To: <1406561793-24630-3-git-send-email-stefano.stabellini@eu.citrix.com>

Hi Stefano,

On 07/28/2014 04:36 PM, Stefano Stabellini wrote:
> diff --git a/xen/include/public/features.h b/xen/include/public/features.h
> index a149aa6..ba753a0 100644
> --- a/xen/include/public/features.h
> +++ b/xen/include/public/features.h
> @@ -94,6 +94,9 @@
>  /* operation as Dom0 is supported */
>  #define XENFEAT_dom0                      11
>  
> +/* Xen also maps grant references at pfn = mfn */
> +#define XENFEAT_grant_map_identity              12
> +

NIT: Every define value are aligned except this one.

Other than that, for the ARM part:

Acked-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall

      reply	other threads:[~2014-07-28 15:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 15:35 [PATCH v5 0/3] map grant refs at pfn = mfn Stefano Stabellini
2014-07-28 15:36 ` [PATCH v5 1/3] xen/x86: introduce is_domain_direct_mapped(d) as ((void)(d), 0) on x86 Stefano Stabellini
2014-07-28 15:36 ` [PATCH v5 2/3] xen: introduce arch_grant_(un)map_page_identity Stefano Stabellini
2014-07-28 15:44   ` Jan Beulich
2014-07-28 15:36 ` [PATCH v5 3/3] xen/arm: introduce XENFEAT_grant_map_identity Stefano Stabellini
2014-07-28 15:52   ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D671C5.906@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).