From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: xen-devel@lists.xenproject.org, "Luis R. Rodriguez" <mcgrof@suse.com>
Subject: Re: [PATCH v8 0/6] xen: systemd support
Date: Mon, 28 Jul 2014 17:52:11 +0100 [thread overview]
Message-ID: <53D67FBB.8030106@citrix.com> (raw)
In-Reply-To: <1406551592.14628.15.camel@kazak.uk.xensource.com>
On 28/07/14 13:46, Ian Campbell wrote:
> On Fri, 2014-07-25 at 19:14 -0700, Luis R. Rodriguez wrote:
>> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>>
>> Here's my v8 series. Quite a bit of patches are alreayd merged
>> on the xen origin/staging branch, this addresses the last feedback
>> from the v7 series and is rebased. It contains two fixes spotted
>> as possible issues by Ian Campbell.
>>
>> I think this is it, after about 2 months of spinning patches. Phew.
> I was about to ack and apply the lot when I noticed that
> dist/install/etc/init.d/xencommons was an empty file. I didn't analyse
> which patch it was, but I guessed at "move module list into a generic
> place" and reverting to the patch before that worked, so I've pushed
> just those, specifically:
>
> 54f2891 autoconf: xen: move standard path variables to config/Paths.mk
> 1846031 oxenstored: also fail if only 1 socket was given by systemd
> bdc74c9 cxenstored: also fail if only 1 socket was given by systemd
>
> I'm a little concerned by the recent lack of comments from systemd folks
> on the final patch, but there didn't seem much benefit in waiting any
> longer. Presumably any issues will get shaken down as people test etc.
>
> Thanks!
>
> Ian.
54f2891 autoconf: xen: move standard path variables to config/Paths.mk
has caused quite a lot of collateral damage on my dev tree. Cheif
amongst the problems is:
andrewcoop@andrewcoop:/local/xen.git/tools$ make clean
/local/xen.git/tools/../tools/Rules.mk:8:
/local/xen.git/tools/../config/Paths.mk: No such file or directory
make: *** No rule to make target
`/local/xen.git/tools/../config/Paths.mk'. Stop.
Running ./configure (without any arguments) does not generate Paths.mk
from Paths.mk.in, which means that I still cant `make clean`
~Andrew
next prev parent reply other threads:[~2014-07-28 16:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 2:14 [PATCH v8 0/6] xen: systemd support Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 1/6] cxenstored: also fail if only 1 socket was given by systemd Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 2/6] oxenstored: " Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 3/6] autoconf: xen: move standard path variables to config/Paths.mk.in Luis R. Rodriguez
2014-08-04 14:24 ` Julien Grall
2014-08-04 14:28 ` Ian Campbell
2014-08-04 14:30 ` Ian Campbell
2014-09-23 7:55 ` Luis R. Rodriguez
2014-09-23 8:15 ` Olaf Hering
2014-09-23 8:19 ` Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 4/6] xencommons: move module list into a generic place Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 5/6] autoconf: xen: enable explicit preference option for xenstored preference Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 6/6] systemd: add xen systemd service and module files Luis R. Rodriguez
2014-07-28 12:46 ` [PATCH v8 0/6] xen: systemd support Ian Campbell
2014-07-28 15:02 ` Luis R. Rodriguez
2014-07-28 15:05 ` Ian Campbell
2014-07-28 17:57 ` Luis R. Rodriguez
2014-07-29 8:56 ` Ian Campbell
2014-07-30 16:22 ` Luis R. Rodriguez
2014-07-30 16:25 ` Ian Campbell
2014-07-30 16:43 ` Luis R. Rodriguez
2014-07-31 8:30 ` Ian Campbell
2014-07-28 16:52 ` Andrew Cooper [this message]
2014-07-28 16:57 ` Andrew Cooper
2014-07-28 17:00 ` Luis R. Rodriguez
2014-07-28 18:33 ` Luis R. Rodriguez
2014-07-29 8:54 ` Ian Campbell
2014-07-29 9:33 ` Andrew Cooper
2014-07-29 9:49 ` Ian Campbell
2014-07-29 10:47 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D67FBB.8030106@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).