From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v8 0/6] xen: systemd support Date: Mon, 28 Jul 2014 17:52:11 +0100 Message-ID: <53D67FBB.8030106@citrix.com> References: <1406340860-8547-1-git-send-email-mcgrof@do-not-panic.com> <1406551592.14628.15.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XBo9o-0004pR-RA for xen-devel@lists.xenproject.org; Mon, 28 Jul 2014 16:52:16 +0000 In-Reply-To: <1406551592.14628.15.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , "Luis R. Rodriguez" Cc: xen-devel@lists.xenproject.org, "Luis R. Rodriguez" List-Id: xen-devel@lists.xenproject.org On 28/07/14 13:46, Ian Campbell wrote: > On Fri, 2014-07-25 at 19:14 -0700, Luis R. Rodriguez wrote: >> From: "Luis R. Rodriguez" >> >> Here's my v8 series. Quite a bit of patches are alreayd merged >> on the xen origin/staging branch, this addresses the last feedback >> from the v7 series and is rebased. It contains two fixes spotted >> as possible issues by Ian Campbell. >> >> I think this is it, after about 2 months of spinning patches. Phew. > I was about to ack and apply the lot when I noticed that > dist/install/etc/init.d/xencommons was an empty file. I didn't analyse > which patch it was, but I guessed at "move module list into a generic > place" and reverting to the patch before that worked, so I've pushed > just those, specifically: > > 54f2891 autoconf: xen: move standard path variables to config/Paths.mk > 1846031 oxenstored: also fail if only 1 socket was given by systemd > bdc74c9 cxenstored: also fail if only 1 socket was given by systemd > > I'm a little concerned by the recent lack of comments from systemd folks > on the final patch, but there didn't seem much benefit in waiting any > longer. Presumably any issues will get shaken down as people test etc. > > Thanks! > > Ian. 54f2891 autoconf: xen: move standard path variables to config/Paths.mk has caused quite a lot of collateral damage on my dev tree. Cheif amongst the problems is: andrewcoop@andrewcoop:/local/xen.git/tools$ make clean /local/xen.git/tools/../tools/Rules.mk:8: /local/xen.git/tools/../config/Paths.mk: No such file or directory make: *** No rule to make target `/local/xen.git/tools/../config/Paths.mk'. Stop. Running ./configure (without any arguments) does not generate Paths.mk from Paths.mk.in, which means that I still cant `make clean` ~Andrew