From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH] libxc: expand cpuid features exposed to PVH guests Date: Mon, 28 Jul 2014 19:39:54 +0200 Message-ID: <53D68AEA.9030800@citrix.com> References: <1406124757-3925-1-git-send-email-roger.pau@citrix.com> <53D65BF0.9050702@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XBouE-0007wH-Vm for xen-devel@lists.xenproject.org; Mon, 28 Jul 2014 17:40:15 +0000 In-Reply-To: <53D65BF0.9050702@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 28/07/14 16:19, David Vrabel wrote: > On 23/07/14 15:12, Roger Pau Monne wrote: >> Expand the cpuid features exposed to PVH guests, this includes >> exposing PSE, PGE and 1GB pages (which will be masked by the >> hypervisor if not supported by the hardware). > > I'm confused. Why is PVH using the PV CPUID policy instead of the HVM one? On PVH guests info.hvm == false, so it falls into the PV cpuid policy. I'm not sure however if this is intentional or not. Roger.