From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [v5][PATCH 1/2] xen:x86:mm:p2m: introduce set_identity_p2m_entry Date: Tue, 29 Jul 2014 10:43:17 +0100 Message-ID: <53D76CB5.4090906@citrix.com> References: <1406616052-11973-1-git-send-email-tiejun.chen@intel.com> <53D763C5020000780002719D@mail.emea.novell.com> <53D74EDC.4010100@intel.com> <53D7754302000078000272AB@mail.emea.novell.com> <53D75F5B.9070002@citrix.com> <53D76756.9070304@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53D76756.9070304@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Chen, Tiejun" , Jan Beulich Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 29/07/14 10:20, Chen, Tiejun wrote: > On 2014/7/29 16:46, Andrew Cooper wrote: >> On 29/07/2014 09:19, Jan Beulich wrote: >>>>>> On 29.07.14 at 09:35, wrote: >>>> On 2014/7/29 15:05, Jan Beulich wrote: >>>>>>>> On 29.07.14 at 08:40, wrote: >>>>>> + struct p2m_domain *p2m = p2m_get_hostp2m(d); >>>>>> + int ret = -EBUSY; >>>>>> + >>>>>> + gfn_lock(p2m, gfn, 0); >>>>>> + >>>>>> + tmp_mfn = p2m->get_entry(p2m, gfn, &p2mt, &a, 0, NULL); >>>>>> + >>>>>> + if ( mfn_valid(tmp_mfn) ) >>>>>> + { >>>>>> + gdprintk(XENLOG_ERR, >>>>>> + "Overlapping RMRRs at %"PRIx64".\n", >>>>>> (paddr_t)gfn); >>>>> Pointless cast: Just use %lx in the format string. Additionally I >>>>> don't >>>>> think the message text is correct: You don't really know whether >>>>> what's there is another RMRR (or that the context you're being >>>>> called in refers to an RMRR at all). On the contrary - if it was an >>>>> RMRR (or to be precise, a previously established identity mapping), >>>>> you'd want to report success. And generally we have no stop at >>>>> the end of log messages. >>>> So just print this, >>>> >>>> + gdprintk(XENLOG_ERR, >>>> + "Overlapping at %lx.\n", (paddr_t)gfn); >>> Of course not - such a message is really meaningless. >>> >>> printk(XENLOG_G_WARNING "Cannot identity map %d:%lx, already mapped >>> to %lx\n", >>> d->domain_id, gfn, mfn_x(mfn)); >>> >>> would be a message conveying all information necessary to >>> gain initial understanding of what the issue is. >> >> This would be better as "map d%d:%lx" to indicate that it is a domid >> before the colon. >> > > "d" seems hard to understand so just pdate this as "map Dom%d:%lx" > > Thanks > Tiejun > d%d is the standard notation for domains (with d%dv%u for domain/vcpus tuples) used increasingly over the Xen codebase. ~Andrew