From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xen: domain_update_node_affinity: Correct the ASSERT Date: Tue, 29 Jul 2014 11:46:00 +0100 Message-ID: <53D77B68.5020904@linaro.org> References: <1406302204-13992-1-git-send-email-julien.grall@linaro.org> <1406568319.4038.17.camel@Solace> <53D68902.9090906@linaro.org> <53D75DF00200007800027143@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XC4v1-0005hM-D4 for xen-devel@lists.xenproject.org; Tue, 29 Jul 2014 10:46:07 +0000 Received: by mail-wi0-f172.google.com with SMTP id n3so5961720wiv.17 for ; Tue, 29 Jul 2014 03:46:05 -0700 (PDT) In-Reply-To: <53D75DF00200007800027143@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Juergen Gross , Keir Fraser , ian.campbell@citrix.com, tim@xen.org, Dario Faggioli , Ian Jackson , George Dunlap , stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org Hi Jan, On 07/29/2014 07:40 AM, Jan Beulich wrote: >>>> On 28.07.14 at 19:31, wrote: >> On 07/28/2014 06:25 PM, Dario Faggioli wrote: >>> On ven, 2014-07-25 at 16:30 +0100, Julien Grall wrote: >>>> The commit "move domain to cpupool0 before destroying it" make Xen crashes >>>> when a domain is destroyed with d->vcpus allocated but no VCPU initialized. >>>> >>> The title of the commit is certainly useful. Perhaps the beginning of >>> the hash would have been too. >> >> I didn't add the commit. Because it will be backported to Xen 4.4. >> >> Would it be fine to point to a Xen 4.5 commit in Xen 4.4 branch? > > Yes. Backports are (supposed to be) identifiable (via some kind of > reference to the backported commit), which would implicitly mean > any commit IDs referenced in the description refer to the master > branch. Furthermore, if someone wanted to look up the > referenced commit, having the (beginning of the) hash in hands > makes this a much more immediate action than just the title; I > believe such a lookup would even succeed on any of the stable > branches, as - luckily - we decided to make them branches rather > than standalone trees. Thank you for the explanation. I will send a v2 today with the commit ID of xen unstable in the message. Regards, -- Julien Grall