From: Don Slutz <dslutz@verizon.com>
To: Jan Beulich <JBeulich@suse.com>, Keir Fraser <keir.xen@gmail.com>,
Don Slutz <dslutz@verizon.com>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Liu Jinsong <jinsong.liu@alibaba-inc.com>,
Christoph Egger <chegger@amazon.de>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
Subject: Re: [PATCH 1/3] cmdline_parse: Also pass bool_assert to OPT_CUSTOM so that parse_bool can be used correctly.
Date: Tue, 29 Jul 2014 16:05:49 -0400 [thread overview]
Message-ID: <53D7FE9D.9080202@terremark.com> (raw)
In-Reply-To: <53D75CCD0200007800027137@mail.emea.novell.com>
On 07/29/14 02:35, Jan Beulich wrote:
>>>> On 28.07.14 at 22:30, <dslutz@verizon.com> wrote:
>> On 07/28/14 15:19, Keir Fraser wrote:
>>> Don Slutz wrote:
> I'd say we should allow what is sensible, and reject nonsense. E.g.
> "no-" on any option that has a value (following a = separator) makes
> no sense. But custom options allowing other than boolean values
> as their value can, when no value (and no = separator) was given,
> meaningfully be prefixed by "no-", which could be resolved by the
> faked up "=no" value I was suggesting in my earlier reply (at once
> dealing with "no-" prefixes on custom options not allowing boolean
> values: their parsing routine will simply reject the faked up "no").
v2 posted with this suggestion.
-Don Slutz
> Jan
>
next prev parent reply other threads:[~2014-07-29 20:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 15:59 [PATCH 0/3] parse_bool fixes Don Slutz
2014-07-28 15:59 ` [PATCH 1/3] cmdline_parse: Also pass bool_assert to OPT_CUSTOM so that parse_bool can be used correctly Don Slutz
2014-07-28 16:06 ` Jan Beulich
2014-07-28 17:12 ` Don Slutz
2014-07-28 19:19 ` Keir Fraser
2014-07-28 20:30 ` Don Slutz
2014-07-29 6:35 ` Jan Beulich
2014-07-29 20:05 ` Don Slutz [this message]
2014-07-28 16:08 ` Andrew Cooper
2014-07-28 16:18 ` Don Slutz
2014-07-28 16:23 ` Andrew Cooper
2014-07-28 19:07 ` Don Slutz
2014-07-28 16:39 ` Jan Beulich
2014-07-28 15:59 ` [PATCH 2/3] xen/console: Better handing of console_timestamps as a boolean_param Don Slutz
2014-07-28 15:59 ` [PATCH 3/3] Adjust parse_vpmu_param use of parse_bool Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7FE9D.9080202@terremark.com \
--to=dslutz@verizon.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=JBeulich@suse.com \
--cc=chegger@amazon.de \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jinsong.liu@alibaba-inc.com \
--cc=keir.xen@gmail.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).