From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, xen-devel@lists.xen.org
Subject: Re: [v6][PATCH 2/2] xen:vtd: missing RMRR mapping while share EPT
Date: Wed, 30 Jul 2014 18:40:00 +0800 [thread overview]
Message-ID: <53D8CB80.1000606@intel.com> (raw)
In-Reply-To: <53D8E4370200007800027986@mail.emea.novell.com>
On 2014/7/30 18:25, Jan Beulich wrote:
>>>> On 30.07.14 at 11:40, <tiejun.chen@intel.com> wrote:
>> From what those codes mean, it just return regardless whether they
>> really conflict. And this is just a good assumption, so if I'm
>> understanding this properly, actually our patches do this thing
>> precisely because we further check if this assumption is true, then take
>> necessary actions.
>
> Except that the pointed out check prevents the code you modify
> from being reached at all, i.e. as long as that check is there it
> doesn't matter (for any passed through USB device) what action
> rmrr_identity_mapping() takes.
>
Sorry, what do you mean?
From my point of view these two patches should be better than drop
simply RMRR for any PT USB device no matter if its really necessary.
Thanks
Tiejun
next prev parent reply other threads:[~2014-07-30 10:40 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 1:36 [v6][PATCH 1/2] xen:x86:mm:p2m: introduce set_identity_p2m_entry Tiejun Chen
2014-07-30 1:36 ` [v6][PATCH 2/2] xen:vtd: missing RMRR mapping while share EPT Tiejun Chen
2014-07-30 8:36 ` Jan Beulich
2014-07-30 8:59 ` Chen, Tiejun
2014-07-30 9:23 ` Jan Beulich
2014-07-30 9:40 ` Chen, Tiejun
2014-07-30 10:25 ` Jan Beulich
2014-07-30 10:40 ` Chen, Tiejun [this message]
2014-07-30 10:47 ` Jan Beulich
2014-07-31 9:45 ` Chen, Tiejun
2014-07-31 22:44 ` Tian, Kevin
2014-08-01 2:07 ` Chen, Tiejun
2014-08-01 6:51 ` Jan Beulich
2014-08-01 7:10 ` Chen, Tiejun
2014-08-01 7:21 ` Jan Beulich
2014-08-01 9:50 ` Chen, Tiejun
2014-08-01 13:47 ` Jan Beulich
2014-08-01 23:22 ` Tian, Kevin
2014-08-04 7:23 ` Jan Beulich
2014-08-03 8:04 ` Chen, Tiejun
2014-08-04 7:31 ` Jan Beulich
2014-08-07 10:59 ` Chen, Tiejun
2014-09-03 9:41 ` Chen, Tiejun
2014-09-03 9:54 ` Jan Beulich
2014-09-12 6:38 ` Chen, Tiejun
2014-09-12 7:19 ` Jan Beulich
2014-09-12 8:27 ` Chen, Tiejun
2014-09-12 16:59 ` Lars Kurth
2014-09-12 21:26 ` Tim Deegan
2014-09-16 1:24 ` Chen, Tiejun
2014-09-17 1:01 ` Chen, Tiejun
2014-09-17 2:42 ` Tian, Kevin
2014-09-17 9:21 ` Jan Beulich
2014-09-18 2:02 ` Zhang, Yang Z
2014-09-18 7:24 ` Jan Beulich
2014-09-18 7:41 ` Zhang, Yang Z
2014-09-18 8:12 ` Jan Beulich
2014-09-17 9:18 ` Jan Beulich
2014-09-18 9:09 ` Jan Beulich
2014-09-19 1:20 ` Chen, Tiejun
2014-09-19 6:26 ` Jan Beulich
2014-09-19 6:50 ` Chen, Tiejun
2014-09-19 7:10 ` Jan Beulich
2014-09-19 7:40 ` Chen, Tiejun
2014-09-19 8:06 ` Jan Beulich
2014-09-19 8:30 ` Chen, Tiejun
2014-09-19 9:26 ` Jan Beulich
2014-09-19 2:43 ` Zhang, Yang Z
2014-09-19 6:33 ` Jan Beulich
2014-07-31 22:29 ` [v6][PATCH 1/2] xen:x86:mm:p2m: introduce set_identity_p2m_entry Tian, Kevin
2014-08-01 2:25 ` Chen, Tiejun
2014-08-01 6:43 ` Jan Beulich
2014-08-01 6:42 ` Jan Beulich
2014-08-01 15:56 ` Tian, Kevin
[not found] <541FB087.4080008@intel.com>
2014-09-22 5:46 ` [v6][PATCH 2/2] xen:vtd: missing RMRR mapping while share EPT Chen, Tiejun
2014-09-22 8:53 ` Jan Beulich
2014-09-22 9:05 ` Chen, Tiejun
2014-09-22 10:36 ` Jan Beulich
2014-09-23 1:56 ` Chen, Tiejun
2014-09-23 12:14 ` Jan Beulich
2014-09-24 0:28 ` Tian, Kevin
2014-09-24 7:54 ` Jan Beulich
2014-09-24 8:23 ` Zhang, Yang Z
2014-09-24 8:35 ` Chen, Tiejun
2014-09-24 8:47 ` Jan Beulich
2014-09-24 8:53 ` Chen, Tiejun
2014-09-24 9:13 ` Jan Beulich
2014-09-25 2:30 ` Zhang, Yang Z
2014-09-25 8:11 ` Jan Beulich
2014-09-26 1:24 ` Zhang, Yang Z
2014-09-26 6:38 ` Jan Beulich
2014-09-30 3:49 ` Zhang, Yang Z
2014-09-30 7:07 ` Jan Beulich
2014-10-02 10:29 ` Tim Deegan
2014-10-03 21:15 ` Tian, Kevin
2014-09-24 8:44 ` Jan Beulich
2014-09-25 1:53 ` Zhang, Yang Z
2014-09-25 8:08 ` Jan Beulich
2014-09-25 14:12 ` Konrad Rzeszutek Wilk
2014-09-25 15:14 ` Jan Beulich
2014-09-28 3:11 ` Chen, Tiejun
2014-09-30 3:51 ` Zhang, Yang Z
2014-09-30 7:09 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D8CB80.1000606@intel.com \
--to=tiejun.chen@intel.com \
--cc=JBeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).