From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH v2 1/1] evtchn: make EVTCHNOP_reset suitable
	for kexec
Date: Wed, 30 Jul 2014 14:42:13 +0100
Message-ID: <53D8F635.3070601@citrix.com>
References: <1406726810-2557-1-git-send-email-vkuznets@redhat.com>
	<1406726810-2557-2-git-send-email-vkuznets@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1XCU94-0005GW-NR
	for xen-devel@lists.xenproject.org; Wed, 30 Jul 2014 13:42:18 +0000
In-Reply-To: <1406726810-2557-2-git-send-email-vkuznets@redhat.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Vitaly Kuznetsov <vkuznets@redhat.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Andrew Jones <drjones@redhat.com>, Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 30/07/14 14:26, Vitaly Kuznetsov wrote:
> It would be nice to allow guests to close all event channels in
> ABI-agnostic way in case of kexec/kdump. EVTCHNOP_reset looks suitable
> for this purpose. However control blocks for vcpus and event array need
> cleanup when FIFO ABI is being used.
> 
> With this change a guest can simply do EVTCHNOP_reset before kexec in
> both 2-level and FIFO cases. It is also important to perform store/console
> channel remapping after such call.

Can you add documentation to xen/include/public/event_channels.h?

> The issue can also be solved by introducing a new EVTCHNOP operation but
> it seems that EVTCHNOP_reset can be reused.
> 
> [The idea was suggested by Ian Campbell, Andrew Cooper, and David Vrabel]
> 
> Changes from v1:

List changes after a --- marker so they don't end up in the final commit
message.

> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -957,6 +957,17 @@ static long evtchn_reset(evtchn_reset_t *r)
>      for ( i = 0; port_is_valid(d, i); i++ )
>          (void)__evtchn_close(d, i);
>  
> +    if ( (d == current->domain) && d->evtchn_fifo )
> +    {
> +        /*
> +         * Guest domain called EVTCHNOP_reset with DOMID_SELF, destroying
> +         * FIFO event array and control blocks, resetting evtchn_port_ops to
> +         * evtchn_port_ops_2l.
> +         */
> +        evtchn_fifo_destroy(d);
> +        evtchn_2l_init(d);

You need to take d->event_lock around this if, or the guest could try to
bind another event whilst the ABI is in an inconsistent state.

David