From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: coverity@xenproject.org, Xen-devel List <xen-devel@lists.xen.org>
Subject: Re: Two Coverty issues found in 0aacc28bd73ba "x86, amd_ucode: support multiple container files appended together"
Date: Wed, 30 Jul 2014 11:09:29 -0500 [thread overview]
Message-ID: <53D918B9.9080109@amd.com> (raw)
In-Reply-To: <53D8E011.80801@citrix.com>
On 7/30/2014 7:07 AM, Andrew Cooper wrote:
> Hi,
>
> The most recent Coverity run has found two issues in cpu_request_microcode()
>
> The first is dead code (CID 1229147). The entire clause starting at 409
> is dead, as there is indeed no possible way to leave the previous while
> loop with error set.
>
> The more concerning is a resource leak (CID 1229148) of mc_amd given
> certain "goto out" bits of error handling. One flagged codepath is via
> the "goto out" on line 405.
>
> Would you mind taking a look at fixing the error handling?
>
>
Ok, I have modified error handling here to simply break out of loop and let
if ( error ) that follows while() to handle free-ing of mc_amd on error.
Have sent patch to fix this.
Thanks,
-Aravind.
prev parent reply other threads:[~2014-07-30 16:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 12:07 Two Coverty issues found in 0aacc28bd73ba "x86, amd_ucode: support multiple container files appended together" Andrew Cooper
2014-07-30 16:09 ` Aravind Gopalakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D918B9.9080109@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=coverity@xenproject.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).