From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH RFC 1/9] xen: arm: rename p2m->first_level to p2m->root. Date: Wed, 30 Jul 2014 17:23:48 +0100 Message-ID: <53D91C14.2010202@linaro.org> References: <1406727891.10402.24.camel@kazak.uk.xensource.com> <3ef2b68c511f3e31de409b76757b95c78b99d750.1406728037.git.ian.campbell@citrix.com> <53D9181C.40505@linaro.org> <1406737195.29218.0.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1406737195.29218.0.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Vijaya Kumar K , Ian Campbell , tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/30/2014 05:19 PM, Ian Campbell wrote: > On Wed, 2014-07-30 at 17:06 +0100, Julien Grall wrote: >> Hi Ian, >> >> On 07/30/2014 02:47 PM, Ian Campbell wrote: >>> From: Ian Campbell >>> >>> This was previously part of Vigaya's "xen/arm: Add 4-level page table >>> for stage 2 translation" but is split out here to make that patch >>> easier to read. I also switched from ->root_level to just ->root. >> >> The last sentence doesn't seem to be relevant. At least I don't find any >> such change in the patch. > > What I meant is that rather than switching from ->first_level to > ->root_level (the "most trivial" change) I switched to just ->root. It's not clear in the commit message as the title is "rename p2m->first_level to p2m->root". IHMO, the sentence seems to come out of nowhere. Regards, -- Julien Grall