From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 3/3] x86/HVM: command line option adjustments
Date: Wed, 30 Jul 2014 12:55:54 -0400
Message-ID: <53D9239A.9070803@oracle.com>
References: <53D933A60200007800027BAE@mail.emea.novell.com>
	<53D934E50200007800027BC2@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <boris.ostrovsky@oracle.com>) id 1XCXAk-00082y-Vu
	for xen-devel@lists.xenproject.org; Wed, 30 Jul 2014 16:56:15 +0000
In-Reply-To: <53D934E50200007800027BC2@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@eu.citrix.com>, Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>, suravee.suthikulpanit@amd.com
List-Id: xen-devel@lists.xenproject.org

On 07/30/2014 12:09 PM, Jan Beulich wrote:
>   
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -70,8 +70,10 @@
>   
>   bool_t __read_mostly hvm_enabled;
>   
> +#ifdef DBG_LEVEL_0
>   unsigned int opt_hvm_debug_level __read_mostly;
>   integer_param("hvm_debug", opt_hvm_debug_level);
> +#endif


Do you think "#ifndef NDEBUG" might be better given that it is what 
defines DBG_LEVEL_0 (and all other DBG_LEVELs)?


-boris