xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] xen: FIFO-based event channel fixes
@ 2014-07-31 15:22 David Vrabel
  0 siblings, 0 replies; 5+ messages in thread
From: David Vrabel @ 2014-07-31 15:22 UTC (permalink / raw)
  To: xen-devel; +Cc: Boris Ostrovsky, David Vrabel

Two fixes and one cleanup for the FIFO-based event channel ABI.

The first fixes an early hang when resuming guests -- this often
occured with PVHVM guests but PV guests for some reason got away with
it...

The second fixes a rare crash if 1023 event channels (or more) were
used -- this would typically only affect dom0.

David

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] xen: FIFO-based event channel fixes
       [not found] <E1XCsBf-0003nI-EP@lists.xen.org>
@ 2014-07-31 16:16 ` Boris Ostrovsky
  2014-07-31 16:17   ` David Vrabel
  0 siblings, 1 reply; 5+ messages in thread
From: Boris Ostrovsky @ 2014-07-31 16:16 UTC (permalink / raw)
  To: David Vrabel, xen-devel

On 07/31/2014 11:22 AM, David Vrabel wrote:
> Two fixes and one cleanup for the FIFO-based event channel ABI.
>
> The first fixes an early hang when resuming guests -- this often
> occured with PVHVM guests but PV guests for some reason got away with
> it...
>
> The second fixes a rare crash if 1023 event channels (or more) were
> used -- this would typically only affect dom0.

Reviewed-by: Boris Ostrovsky@oracle.com <boris.ostrovsky@oracle.com>

(although evtchn_fifo_init_control_block() vs init_control_block() 
naming in patch 1 is slightly confusing I think).

-boris

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] xen: FIFO-based event channel fixes
  2014-07-31 16:16 ` [PATCH 0/3] xen: FIFO-based event channel fixes Boris Ostrovsky
@ 2014-07-31 16:17   ` David Vrabel
  2014-07-31 16:27     ` Boris Ostrovsky
  0 siblings, 1 reply; 5+ messages in thread
From: David Vrabel @ 2014-07-31 16:17 UTC (permalink / raw)
  To: Boris Ostrovsky, xen-devel

On 31/07/14 17:16, Boris Ostrovsky wrote:
> On 07/31/2014 11:22 AM, David Vrabel wrote:
>> Two fixes and one cleanup for the FIFO-based event channel ABI.
>>
>> The first fixes an early hang when resuming guests -- this often
>> occured with PVHVM guests but PV guests for some reason got away with
>> it...
>>
>> The second fixes a rare crash if 1023 event channels (or more) were
>> used -- this would typically only affect dom0.
> 
> Reviewed-by: Boris Ostrovsky@oracle.com <boris.ostrovsky@oracle.com>
> 
> (although evtchn_fifo_init_control_block() vs init_control_block()
> naming in patch 1 is slightly confusing I think).

I'll change the first to evtchn_fifo_alloc_control_block().  Is that ok?

David

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] xen: FIFO-based event channel fixes
  2014-07-31 16:17   ` David Vrabel
@ 2014-07-31 16:27     ` Boris Ostrovsky
  0 siblings, 0 replies; 5+ messages in thread
From: Boris Ostrovsky @ 2014-07-31 16:27 UTC (permalink / raw)
  To: David Vrabel, xen-devel

On 07/31/2014 12:17 PM, David Vrabel wrote:
> On 31/07/14 17:16, Boris Ostrovsky wrote:
>> On 07/31/2014 11:22 AM, David Vrabel wrote:
>>> Two fixes and one cleanup for the FIFO-based event channel ABI.
>>>
>>> The first fixes an early hang when resuming guests -- this often
>>> occured with PVHVM guests but PV guests for some reason got away with
>>> it...
>>>
>>> The second fixes a rare crash if 1023 event channels (or more) were
>>> used -- this would typically only affect dom0.
>> Reviewed-by: Boris Ostrovsky@oracle.com <boris.ostrovsky@oracle.com>
>>
>> (although evtchn_fifo_init_control_block() vs init_control_block()
>> naming in patch 1 is slightly confusing I think).
> I'll change the first to evtchn_fifo_alloc_control_block().  Is that ok?
>


Yes, thanks.

-boris

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] xen: FIFO-based event channel fixes
       [not found] <E1XCsBf-0003nI-Fu@lists.xen.org>
@ 2014-07-31 17:23 ` David Vrabel
  0 siblings, 0 replies; 5+ messages in thread
From: David Vrabel @ 2014-07-31 17:23 UTC (permalink / raw)
  To: David Vrabel, xen-devel; +Cc: Boris Ostrovsky

On 31/07/14 16:22, David Vrabel wrote:
> Two fixes and one cleanup for the FIFO-based event channel ABI.
> 
> The first fixes an early hang when resuming guests -- this often
> occured with PVHVM guests but PV guests for some reason got away with
> it...
> 
> The second fixes a rare crash if 1023 event channels (or more) were
> used -- this would typically only affect dom0.

Applied to devel/for-linus-2.17 since they're not a 3.16 regression and
3.16 is nearly here.

David

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-07-31 17:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1XCsBf-0003nI-EP@lists.xen.org>
2014-07-31 16:16 ` [PATCH 0/3] xen: FIFO-based event channel fixes Boris Ostrovsky
2014-07-31 16:17   ` David Vrabel
2014-07-31 16:27     ` Boris Ostrovsky
     [not found] <E1XCsBf-0003nI-Fu@lists.xen.org>
2014-07-31 17:23 ` David Vrabel
2014-07-31 15:22 David Vrabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).