From: "Jan Beulich" <JBeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>,
Jun Nakajima <jun.nakajima@intel.com>,
Eddie Dong <eddie.dong@intel.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
suravee.suthikulpanit@amd.com,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 3/3] x86/HVM: command line option adjustments
Date: Fri, 01 Aug 2014 07:31:08 +0100 [thread overview]
Message-ID: <53DB504C0200007800028432@mail.emea.novell.com> (raw)
In-Reply-To: <53D9239A.9070803@oracle.com>
>>> On 30.07.14 at 18:55, <boris.ostrovsky@oracle.com> wrote:
> On 07/30/2014 12:09 PM, Jan Beulich wrote:
>>
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -70,8 +70,10 @@
>>
>> bool_t __read_mostly hvm_enabled;
>>
>> +#ifdef DBG_LEVEL_0
>> unsigned int opt_hvm_debug_level __read_mostly;
>> integer_param("hvm_debug", opt_hvm_debug_level);
>> +#endif
>
>
> Do you think "#ifndef NDEBUG" might be better given that it is what
> defines DBG_LEVEL_0 (and all other DBG_LEVELs)?
No, specifically not: If someone wants to alter the behavior to e.g.
include the option (and the effect it takes) in a non-debug build, the
way it's done this requires code modification in _exactly one place_.
Jan
next prev parent reply other threads:[~2014-08-01 6:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 16:04 [PATCH 0/3] x86: command line option adjustments Jan Beulich
2014-07-30 16:07 ` [PATCH 1/3] x86/ACPI: " Jan Beulich
2014-07-30 16:08 ` [PATCH 2/3] x86/APIC: " Jan Beulich
2014-07-30 16:09 ` [PATCH 3/3] x86/HVM: " Jan Beulich
2014-07-30 16:55 ` Boris Ostrovsky
2014-07-31 22:55 ` Tian, Kevin
2014-08-01 6:31 ` Jan Beulich [this message]
2014-08-01 23:23 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB504C0200007800028432@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=boris.ostrovsky@oracle.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).