From: "Jan Beulich" <JBeulich@suse.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, julien.grall@linaro.org,
tim@xen.org, xen-devel@lists.xen.org,
Roy Franz <roy.franz@linaro.org>, Fu Wei <fu.wei@linaro.org>
Subject: Re: [PATCH RFC 1/2] xen: refactor physical address space compression support into common code
Date: Fri, 01 Aug 2014 09:32:44 +0100 [thread overview]
Message-ID: <53DB6CCC02000078000284DF@mail.emea.novell.com> (raw)
In-Reply-To: <1bdc9d35.859@novprvlin0050.provo.novell.com>
>>> On 31.07.14 at 13:01, <ian.campbell@citrix.com> wrote:
> The "pdx compression" functionality will be useful on ARM as well.
>
> Move the code to common code+header and introduce HAS_PDX to control when it is
> built. L2_PAGETABLE_SHIFT is x86 specific, so introduce PDX_GROUP_SHIFT to
> abstract it out.
>
> ARM has no need for superpage compression (yet?) and lacks SUPERPAGE_SHIFT so
> those functions (spage_to_mfn et al) are not moved.
>
> No affect on x86 and no change for ARM (yet).
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
On the basis this is, as it looks to be, pure code motion except for the
few obvious places where other adjustments are needed:
Acked-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2014-08-01 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XCo59-0002Jo-Ge@lists.xen.org>
2014-07-31 11:01 ` [PATCH RFC 1/2] xen: refactor physical address space compression support into common code Ian Campbell
[not found] ` <1bdc9d35.859@novprvlin0050.provo.novell.com>
2014-08-01 8:32 ` Jan Beulich [this message]
2014-08-05 9:20 ` [PATCH RFC 0/2] Support for spare physical address space on ARM Ian Campbell
[not found] ` <53da2210.8511ec0a.4375.46cdSMTPIN_ADDED_MISSING@mx.google.com>
2014-08-07 15:56 ` [PATCH RFC 1/2] xen: refactor physical address space compression support into common code Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB6CCC02000078000284DF@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=fu.wei@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).