From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH RFC 1/2] xen: refactor physical address space compression support into common code Date: Fri, 01 Aug 2014 09:32:44 +0100 Message-ID: <53DB6CCC02000078000284DF@mail.emea.novell.com> References: <1bdc9d35.859@novprvlin0050.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1bdc9d35.859@novprvlin0050.provo.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, Roy Franz , Fu Wei List-Id: xen-devel@lists.xenproject.org >>> On 31.07.14 at 13:01, wrote: > The "pdx compression" functionality will be useful on ARM as well. > > Move the code to common code+header and introduce HAS_PDX to control when it is > built. L2_PAGETABLE_SHIFT is x86 specific, so introduce PDX_GROUP_SHIFT to > abstract it out. > > ARM has no need for superpage compression (yet?) and lacks SUPERPAGE_SHIFT so > those functions (spage_to_mfn et al) are not moved. > > No affect on x86 and no change for ARM (yet). > > Signed-off-by: Ian Campbell On the basis this is, as it looks to be, pure code motion except for the few obvious places where other adjustments are needed: Acked-by: Jan Beulich