From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v6][PATCH 2/2] xen:vtd: missing RMRR mapping while share EPT Date: Sun, 03 Aug 2014 16:04:17 +0800 Message-ID: <53DDED01.7000607@intel.com> References: <1406684186-12788-1-git-send-email-tiejun.chen@intel.com> <1406684186-12788-2-git-send-email-tiejun.chen@intel.com> <53D8CAC402000078000278E9@mail.emea.novell.com> <53D8B408.1010409@intel.com> <53D8D5A0020000780002792A@mail.emea.novell.com> <53D8BD70.7040905@intel.com> <53D8E4370200007800027986@mail.emea.novell.com> <53D8CB80.1000606@intel.com> <53D8E95A02000078000279BD@mail.emea.novell.com> <53DA103B.4000308@intel.com> <53DB552C020000780002846D@mail.emea.novell.com> <53DB3D57.5010107@intel.com> <53DB5C3002000078000284A4@mail.emea.novell.com> <53DB62EA.4090502@intel.com> <53DBB691020000780002875B@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53DBB691020000780002875B@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 2014/8/1 21:47, Jan Beulich wrote: >>>> On 01.08.14 at 11:50, wrote: >> On 2014/8/1 15:21, Jan Beulich wrote: >>>>>> On 01.08.14 at 09:10, wrote: >>>> On 2014/8/1 14:51, Jan Beulich wrote: >>>>>>>> On 31.07.14 at 11:45, wrote: >>>>>> Additionally, I'm trying to figure out that solution. As I mentioned >>>>>> previously, I think we can reserve all RMRR once when a guest call >>>>>> XENMEM_machine_memory_map to create its own memory. What about this >>>>>> idea? Or other better suggestions? >>>>> >>>>> I don't think any HVM guest would ever call this, even more so that >>>>> the call is restricted to Dom0. The reservation needs to be done >>>> >>>> Thanks for your correction. Actually I'm also afraid I may not find a >>>> correct place where I want to go indeed since I'm not familiar this >>>> process. >>>> >>>>> when guest memory gets populated (and its E820 constructed). >>>> >>>> Could you hint me where this action is covered? >>> >>> Memory population happens in tools/libxc/xc_hvm_build.c:setup_guest(), >>> the E820 for the guest gets constructed in hvmloader (just grep for >>> [eE]820). >>> >> >> Thanks for your information. >> >> With further looking into this, instead of XENMEM_machine_memory_map, I >> think we can go XENMEM_set_memory_map path, right? > > I'm not sure - this may be an additional piece to be done for > consistency (if the domain builder doesn't already call this), but > since hvmloader doesn't appear to call XENMEM_memory_map it > won't do on its own I'm afraid. > Yes, current hvmloader can't do this on its own. But in PV case, e820_host, seems be a refereed way to our goal. Even we may reuse some codes here so its a convenient approach. Additionally, I want to know if patch v6 is fine to be acked. Thanks Tiejun