From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v10 08/12] tools/libxl: parse optional start gfn from the iomem config option Date: Mon, 04 Aug 2014 14:39:39 +0100 Message-ID: <53DF8D1B.4010603@linaro.org> References: <1406585529-32193-1-git-send-email-avanzini.arianna@gmail.com> <1406585529-32193-9-git-send-email-avanzini.arianna@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1406585529-32193-9-git-send-email-avanzini.arianna@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Arianna Avanzini , xen-devel@lists.xen.org Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org Hi Arianna, On 07/28/2014 11:12 PM, Arianna Avanzini wrote: > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index 0686f96..3bfe65b 100644 > --- a/tools/libxl/libxl_create.c > +++ b/tools/libxl/libxl_create.c > @@ -102,6 +102,8 @@ static int sched_params_valid(libxl__gc *gc, > int libxl__domain_build_info_setdefault(libxl__gc *gc, > libxl_domain_build_info *b_info) > { > + int i; > + I've tried to build this series and get the following error in libxl: libxl_create.c: In function =91libxl__domain_build_info_setdefault=92: libxl_create.c:195:13: error: declaration of =91i=92 shadows a previous loc= al [-Werror=3Dshadow] int i; ^ libxl_create.c:106:9: error: shadowed declaration is here [-Werror=3Dshadow] int i; ^ cc1: all warnings being treated as errors I think you have to drop the variable i defined around line 195. Regards, -- = Julien Grall