From: Julien Grall <julien.grall@linaro.org>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH v8 3/6] autoconf: xen: move standard path variables to config/Paths.mk.in
Date: Mon, 04 Aug 2014 15:24:23 +0100 [thread overview]
Message-ID: <53DF9797.7070600@linaro.org> (raw)
In-Reply-To: <1406340860-8547-4-git-send-email-mcgrof@do-not-panic.com>
Hi,
On 07/26/2014 03:14 AM, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>
> This moves all generic path variables to a new the config/Paths.mk.in
> input source file to be processed at configure time, tons of files use
> these so this just share them. This also paves the way to let us
> easily dynamically configure these with autoconf, for now we leave the
> same presets as was present before.
>
> This work was prompted by looking for an autoconf way to do
> replacements for the hotplug global file, while at it I realized
> that a few other files use the same variables and have in places
> around the tree the same constructs for generating their own
> files. This makes use of the old buildmakevars2file() but generalizes
> the definition of the paths at configure time and spreads the
> new definitions out throughout the build system.
>
> This has no impact on building the hypervisor and extras/mini-os,
> you do not need to, and are not expected to, run configure to build
> those targets.
>
> While at it lets add some documentation on the for the two files on
> the source file, we can expand further details on the wiki [0].
>
> [0] http://wiki.xen.org/wiki/Category:Host_Configuration#System_wide_xen_configuration
With this patch applied on xen tree (see commit 54f2891), the libraries will always be
copied in /usr/local/lib even if --prefix=/usr is specified to the configure.
It's a bit annoying as I used this options daily to build Xen and we have test suite relying
on this option.
Here my config/Paths.mk generated:
# Xen system configuration
# ========================
#
# Xen uses a set of variables for system configuration and at build time,
# because of this these variables are defined on one master input source file
# and is generated after running ./configure. The master source is located
# on the xen source tree at under config/Paths.mk.in and it is used to
# generate shell or header files by the build system upon demand through the
# use of the helper makefile helper buildmakevars2file().
#
# For more documentation you can refer to the wiki:
#
# http://wiki.xen.org/wiki/Category:Host_Configuration#System_wide_xen_configuration
SBINDIR := /usr/sbin
BINDIR := /usr/bin
LIBEXEC := /usr/lib/xen/bin
SHAREDIR := /usr/share
LIBDIR := /usr/local/lib
XEN_RUN_DIR := /var/run/xen
XEN_LOG_DIR := /var/log/xen
XEN_LIB_STORED := /var/lib/xenstored
CONFIG_DIR := /etc
XEN_LOCK_DIR := /var/lock
XEN_PAGING_DIR := /var/lib/xen/xenpaging
PRIVATE_PREFIX := /usr/local/lib/xen
PRIVATE_PREFIX := /usr/local/lib/xen
PRIVATE_BINDIR := /usr/local/lib/xen/bin
XENFIRMWAREDIR := /usr/lib/xen/boot
XEN_CONFIG_DIR := /etc/xen
XEN_SCRIPT_DIR := /etc/xen/scripts
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-08-04 14:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 2:14 [PATCH v8 0/6] xen: systemd support Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 1/6] cxenstored: also fail if only 1 socket was given by systemd Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 2/6] oxenstored: " Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 3/6] autoconf: xen: move standard path variables to config/Paths.mk.in Luis R. Rodriguez
2014-08-04 14:24 ` Julien Grall [this message]
2014-08-04 14:28 ` Ian Campbell
2014-08-04 14:30 ` Ian Campbell
2014-09-23 7:55 ` Luis R. Rodriguez
2014-09-23 8:15 ` Olaf Hering
2014-09-23 8:19 ` Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 4/6] xencommons: move module list into a generic place Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 5/6] autoconf: xen: enable explicit preference option for xenstored preference Luis R. Rodriguez
2014-07-26 2:14 ` [PATCH v8 6/6] systemd: add xen systemd service and module files Luis R. Rodriguez
2014-07-28 12:46 ` [PATCH v8 0/6] xen: systemd support Ian Campbell
2014-07-28 15:02 ` Luis R. Rodriguez
2014-07-28 15:05 ` Ian Campbell
2014-07-28 17:57 ` Luis R. Rodriguez
2014-07-29 8:56 ` Ian Campbell
2014-07-30 16:22 ` Luis R. Rodriguez
2014-07-30 16:25 ` Ian Campbell
2014-07-30 16:43 ` Luis R. Rodriguez
2014-07-31 8:30 ` Ian Campbell
2014-07-28 16:52 ` Andrew Cooper
2014-07-28 16:57 ` Andrew Cooper
2014-07-28 17:00 ` Luis R. Rodriguez
2014-07-28 18:33 ` Luis R. Rodriguez
2014-07-29 8:54 ` Ian Campbell
2014-07-29 9:33 ` Andrew Cooper
2014-07-29 9:49 ` Ian Campbell
2014-07-29 10:47 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DF9797.7070600@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).