From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v8 3/6] autoconf: xen: move standard path variables to config/Paths.mk.in Date: Mon, 04 Aug 2014 15:24:23 +0100 Message-ID: <53DF9797.7070600@linaro.org> References: <1406340860-8547-1-git-send-email-mcgrof@do-not-panic.com> <1406340860-8547-4-git-send-email-mcgrof@do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XEJBg-0001K4-CJ for xen-devel@lists.xenproject.org; Mon, 04 Aug 2014 14:24:32 +0000 Received: by mail-we0-f181.google.com with SMTP id k48so7810956wev.40 for ; Mon, 04 Aug 2014 07:24:29 -0700 (PDT) In-Reply-To: <1406340860-8547-4-git-send-email-mcgrof@do-not-panic.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Luis R. Rodriguez" , xen-devel@lists.xenproject.org Cc: Keir Fraser , Ian Campbell , Tim Deegan , "Luis R. Rodriguez" , Ian Jackson , Jan Beulich , Samuel Thibault List-Id: xen-devel@lists.xenproject.org Hi, On 07/26/2014 03:14 AM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This moves all generic path variables to a new the config/Paths.mk.in > input source file to be processed at configure time, tons of files use > these so this just share them. This also paves the way to let us > easily dynamically configure these with autoconf, for now we leave the > same presets as was present before. > > This work was prompted by looking for an autoconf way to do > replacements for the hotplug global file, while at it I realized > that a few other files use the same variables and have in places > around the tree the same constructs for generating their own > files. This makes use of the old buildmakevars2file() but generalizes > the definition of the paths at configure time and spreads the > new definitions out throughout the build system. > > This has no impact on building the hypervisor and extras/mini-os, > you do not need to, and are not expected to, run configure to build > those targets. > > While at it lets add some documentation on the for the two files on > the source file, we can expand further details on the wiki [0]. > > [0] http://wiki.xen.org/wiki/Category:Host_Configuration#System_wide_xen_configuration With this patch applied on xen tree (see commit 54f2891), the libraries will always be copied in /usr/local/lib even if --prefix=/usr is specified to the configure. It's a bit annoying as I used this options daily to build Xen and we have test suite relying on this option. Here my config/Paths.mk generated: # Xen system configuration # ======================== # # Xen uses a set of variables for system configuration and at build time, # because of this these variables are defined on one master input source file # and is generated after running ./configure. The master source is located # on the xen source tree at under config/Paths.mk.in and it is used to # generate shell or header files by the build system upon demand through the # use of the helper makefile helper buildmakevars2file(). # # For more documentation you can refer to the wiki: # # http://wiki.xen.org/wiki/Category:Host_Configuration#System_wide_xen_configuration SBINDIR := /usr/sbin BINDIR := /usr/bin LIBEXEC := /usr/lib/xen/bin SHAREDIR := /usr/share LIBDIR := /usr/local/lib XEN_RUN_DIR := /var/run/xen XEN_LOG_DIR := /var/log/xen XEN_LIB_STORED := /var/lib/xenstored CONFIG_DIR := /etc XEN_LOCK_DIR := /var/lock XEN_PAGING_DIR := /var/lib/xen/xenpaging PRIVATE_PREFIX := /usr/local/lib/xen PRIVATE_PREFIX := /usr/local/lib/xen PRIVATE_BINDIR := /usr/local/lib/xen/bin XENFIRMWAREDIR := /usr/lib/xen/boot XEN_CONFIG_DIR := /etc/xen XEN_SCRIPT_DIR := /etc/xen/scripts Regards, -- Julien Grall