From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Subject: Re: [PATCH] qemu-xen-trad: free all the pirqs for
 msi/msix when driver unloads
Date: Tue, 05 Aug 2014 15:31:34 +0800
Message-ID: <53E08856.1070502@oracle.com>
References: <1396975483-31442-1-git-send-email-konrad.wilk@oracle.com>
	<1396975483-31442-2-git-send-email-konrad.wilk@oracle.com>
	<21428.8198.371406.754367@mariner.uk.xensource.com>
	<53B4CA12.80709@oracle.com>
	<20140703175415.GB13710@konrad-lan.dumpdata.com>
	<53B60382.2070506@oracle.com>
	<20140707204010.GA17821@laptop.dumpdata.com>
	<53BB4587.2050106@oracle.com>
	<20140804140108.GB18425@laptop.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <zhenzhong.duan@oracle.com>) id 1XEZDq-0002Yk-B6
	for xen-devel@lists.xenproject.org; Tue, 05 Aug 2014 07:31:50 +0000
In-Reply-To: <20140804140108.GB18425@laptop.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <Ian.Jackson@eu.citrix.com>, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org


On 2014-8-4 22:01, Konrad Rzeszutek Wilk wrote:
> On Tue, Jul 08, 2014 at 09:12:39AM +0800, Zhenzhong Duan wrote:
>> On 2014-7-8 4:40, Konrad Rzeszutek Wilk wrote:
>>> On Fri, Jul 04, 2014 at 09:29:38AM +0800, Zhenzhong Duan wrote:
>>>> On 2014-7-4 1:54, Konrad Rzeszutek Wilk wrote:
>>>>> On Thu, Jul 03, 2014 at 11:12:18AM +0800, Zhenzhong Duan wrote:
>>>>>> There is a patch dependency missed.
>>>>> Is that one upstream as well? Or does it not need to be?
>>>>> If it is upstream, what is the title/commit id of that one?
>>>>>
>>>>> Thank you!
>>>> It's upstream, see detail below
>>> [konrad@build-external qemu-xen-dir]$ pwd
>>> /home/konrad/xtt-x86_64/xen/tools/qemu-xen-dir
>>> [konrad@build-external qemu-xen-dir]$ git show adf74189dd58014744a4b8c9d64407d629da5e2f
>>> fatal: bad object adf74189dd58014744a4b8c9d64407d629da5e2f
>>> [konrad@build-external qemu-xen-dir]$ git log --grep="clear all MSI"
>>> [konrad@build-external qemu-xen-dir]$
>>>
>>> ?
>> Sorry, I mean qemu-xen-traditional upstream git
> Ok, is that patch upstream? Should it be upstream? If so, had it been
> posted in the past?
It's already in qemu-xen upstream, see below

void xen_pt_msi_disable(XenPCIPassthroughState *s)
{
.......
     /* clear msi info */
     msi->flags &= ~PCI_MSI_FLAGS_ENABLE;
     msi->initialized = false;
     msi->mapped = false;
     msi->pirq = XEN_PT_UNASSIGNED_PIRQ;
}